Modal Component #1135

s1mahanty · 2024-03-20T05:43:38Z

Description

Related Issue

FORMS-13470

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

adobe-bot · 2024-03-20T05:56:12Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-20T05:56:12Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	100	100	73

adobe-bot · 2024-03-20T06:02:48Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-20T06:02:48Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	87	100	100	73

adobe-bot · 2024-03-20T06:02:59Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-20T06:04:58Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-20T06:05:00Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

codecov · 2024-03-20T06:07:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (fc59181) to head (17cb589).
Report is 2 commits behind head on dev.

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #1135      +/-   ##
============================================
+ Coverage     80.75%   80.91%   +0.16%     
- Complexity      773      778       +5     
============================================
  Files            91       92       +1     
  Lines          2110     2112       +2     
  Branches        285      285              
============================================
+ Hits           1704     1709       +5     
+ Misses          252      249       -3     
  Partials        154      154

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adobe-bot · 2024-03-20T09:25:11Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	90	100	100	73

adobe-bot · 2024-03-20T09:25:11Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-20T09:25:22Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-20T09:26:18Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-20T11:27:16Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	100	100	73

adobe-bot · 2024-03-20T11:27:16Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-20T11:27:27Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-20T11:28:40Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-21T04:33:04Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	100	100	73

adobe-bot · 2024-03-21T04:33:04Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-21T04:33:15Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-21T04:36:02Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-21T04:36:52Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-27T10:17:32Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	89	100	100	73

adobe-bot · 2024-03-27T10:17:32Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-27T11:56:39Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	90	100	100	73

adobe-bot · 2024-03-27T11:56:39Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-27T11:56:50Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-27T11:58:41Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-27T11:58:46Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-27T12:44:57Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	89	100	100	73

adobe-bot · 2024-03-27T12:44:57Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-27T12:45:08Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-27T12:47:16Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-27T12:47:34Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-27T14:35:44Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-27T14:35:44Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	87	100	100	73

adobe-bot · 2024-03-27T14:35:58Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-27T14:36:28Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-27T14:40:43Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

...ore/src/main/java/com/adobe/cq/forms/core/components/internal/models/v1/form/ButtonImpl.java

....apps/src/main/content/jcr_root/apps/core/fd/components/form/modal/v1/modal/_cq_template.xml

adobe-bot · 2024-03-28T19:48:45Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-28T19:48:45Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	90	100	100	73

adobe-bot · 2024-03-28T19:48:56Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-28T19:51:11Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-28T19:51:14Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

github-actions bot force-pushed the inside-gig2_modal branch from a4ac0d0 to 40d3ab7 Compare March 20, 2024 05:43

s1mahanty force-pushed the inside-gig2_modal branch from 40d3ab7 to c9b6d08 Compare March 20, 2024 09:05

github-actions bot force-pushed the inside-gig2_modal branch from c9b6d08 to b47e7c0 Compare March 20, 2024 09:05

s1mahanty force-pushed the inside-gig2_modal branch from b47e7c0 to 0d258f9 Compare March 21, 2024 04:02

github-actions bot force-pushed the inside-gig2_modal branch from 0d258f9 to f35e802 Compare March 21, 2024 04:02

s1mahanty force-pushed the inside-gig2_modal branch from f35e802 to 6590d4d Compare March 27, 2024 09:56

github-actions bot force-pushed the inside-gig2_modal branch from 6590d4d to a42a065 Compare March 27, 2024 09:56

s1mahanty added 7 commits March 27, 2024 11:33

Baseline template for Modal Component

119559d

FORMS-13470: Modal component css, js

b45d269

FORMS-13470: runtime test case for modal

f13326d

FORMS-13470: add temp css for the test

ba4dc63

Changes made in ButtonImpl to align with the schema

8f735de

FORMS-13470: Added the marker interface for Modal.

db8c2f0

Incorporated review comments

17cb589

github-actions bot force-pushed the inside-gig2_modal branch from 02da7a3 to 17cb589 Compare March 27, 2024 11:33

barshat7 reviewed Mar 28, 2024

View reviewed changes

...ore/src/main/java/com/adobe/cq/forms/core/components/internal/models/v1/form/ButtonImpl.java Show resolved Hide resolved

barshat7 reviewed Mar 28, 2024

View reviewed changes

....apps/src/main/content/jcr_root/apps/core/fd/components/form/modal/v1/modal/_cq_template.xml Show resolved Hide resolved

Modal Component #1135

Are you sure you want to change the base?

Modal Component #1135

Conversation

s1mahanty commented Mar 20, 2024 • edited

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

adobe-bot commented Mar 20, 2024

Lighthouse scores (desktop)

adobe-bot commented Mar 20, 2024

Lighthouse scores (mobile)

adobe-bot commented Mar 20, 2024

Lighthouse scores (desktop)

adobe-bot commented Mar 20, 2024

Lighthouse scores (mobile)

adobe-bot commented Mar 20, 2024

Accessibility Violations Found

adobe-bot commented Mar 20, 2024

Accessibility Violations Found

adobe-bot commented Mar 20, 2024

Accessibility Violations Found

codecov bot commented Mar 20, 2024 • edited

Codecov Report

adobe-bot commented Mar 20, 2024

Lighthouse scores (mobile)

adobe-bot commented Mar 20, 2024

Lighthouse scores (desktop)

adobe-bot commented Mar 20, 2024

Accessibility Violations Found

adobe-bot commented Mar 20, 2024

Accessibility Violations Found

adobe-bot commented Mar 20, 2024

Lighthouse scores (mobile)

adobe-bot commented Mar 20, 2024

Lighthouse scores (desktop)

adobe-bot commented Mar 20, 2024

Accessibility Violations Found

adobe-bot commented Mar 20, 2024

Accessibility Violations Found

adobe-bot commented Mar 21, 2024

Lighthouse scores (mobile)

adobe-bot commented Mar 21, 2024

Lighthouse scores (desktop)

adobe-bot commented Mar 21, 2024

Accessibility Violations Found

adobe-bot commented Mar 21, 2024

Accessibility Violations Found

adobe-bot commented Mar 21, 2024

Accessibility Violations Found

adobe-bot commented Mar 27, 2024

Lighthouse scores (mobile)

adobe-bot commented Mar 27, 2024

Lighthouse scores (desktop)

adobe-bot commented Mar 27, 2024

Lighthouse scores (mobile)

adobe-bot commented Mar 27, 2024

Lighthouse scores (desktop)

adobe-bot commented Mar 27, 2024

Accessibility Violations Found

adobe-bot commented Mar 27, 2024

Accessibility Violations Found

adobe-bot commented Mar 27, 2024

Accessibility Violations Found

adobe-bot commented Mar 27, 2024

Lighthouse scores (mobile)

adobe-bot commented Mar 27, 2024

Lighthouse scores (desktop)

adobe-bot commented Mar 27, 2024

Accessibility Violations Found

adobe-bot commented Mar 27, 2024

Accessibility Violations Found

adobe-bot commented Mar 27, 2024

Accessibility Violations Found

adobe-bot commented Mar 27, 2024

Lighthouse scores (desktop)

s1mahanty commented Mar 20, 2024 •

edited

codecov bot commented Mar 20, 2024 •

edited