Feature/imagechoice-component #1091
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imagechoice-component-Updated dialog option label and corresponding java files
imagechoice-component-Updated imagechoiceview js file
imagechoice-component-update editDialog js
Updated imagechoice.html file
imagechoice-component- Updated ImageChoiceImpl java file
Feature/imagechoice component
Feature/imagechoice dev
imagechoice-component - updated imagechoiceview js and imagechoiceimp…
imagechoice-component-updated imagechoiceview js file
imagechoice-component - Added Unit Test cases
Feature/imagechoice dev
imagechoice-component- updated readme file
imagechoice-component - removed notnull
imagechoice-component - Added ui.tests - authoring spec.js
barshat7
reviewed
Apr 1, 2024
| IMAGE("image"); | ||
| IMAGE("image"), | ||
|
|
||
| IMAGECHOICE("imagechoice"); |
There was a problem hiding this comment.
fieldType 'imagechoice' does not exists, I believe it should be 'checkbox'
There was a problem hiding this comment.
The reason for creating a new field type is that the image choice component is a composite multi/single selection type, and it will not store values as an enum.
Feature/imagechoice dev
imagechoice component - updated ui test runtime js and added sample
pavi41
reviewed
Apr 29, 2024
There was a problem hiding this comment.
Remove the code at line 130(this.toggle(enabled, FormView.Constants.ARIA_DISABLED, true);), as it will add aria-disabled attribute on the parent div. Aria-disabled attribute is applied on the input, not on the div.
There was a problem hiding this comment.
Removed the code at line number - 130.
ImageChoiceComponent - Implemented Code Review feedback [Remove the code at line 130(this.toggle(enabled, FormView.Constants.ARIA_DISABLED, true);), as it will add aria-disabled attribute on the parent div. Aria-disabled attribute is applied on the input, not on the div.]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adaptive Form Image Choice (v1)
Description
This PR with code changes for Adaptive Form Image Choice Component (V1)
This component still needs to be updated and tested accordingly.
The code changes made so far reflect the current progress.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: