Initial commit for the AF password box core component #1090
Conversation
Updated Javascript code for toggle password visibility. Html code cleanups
| @@ -0,0 +1,8 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:cq="http://www.day.com/jcr/cq/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0" | |||
| cq:icon="abc" | |||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:cq="http://www.day.com/jcr/cq/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0" | ||
| cq:icon="abc" | ||
| jcr:description="Add a field to password strings." |
There was a problem hiding this comment.
Add a field to capture password
| 1. `./jcr:title` - defines the label to use for this field | ||
| 2. `./hideTitle` - if set to `true`, the label of this field will be hidden | ||
| 3. `./name` - defines the name of the field, which will be submitted with the form data | ||
| 4. `./default` - defines the default value of the field |
There was a problem hiding this comment.
default should not be there in password
| <items jcr:primaryType="nt:unstructured"> | ||
| <customFormatKey | ||
| jcr:primaryType="nt:unstructured" | ||
| fieldDescription="The text input format that will be displayed in formatter dropdown in dialog." |
There was a problem hiding this comment.
The patterns which are listed for text input shouldn't appear in password
...n/content/jcr_root/apps/core/fd/components/form/password/v1/password/_cq_dialog/.content.xml
Show resolved
Hide resolved
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| ******************************************************************************/ |
There was a problem hiding this comment.
This needs to have empty BEM classes, like other components
There was a problem hiding this comment.
updated with empty BEM classes.
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| ******************************************************************************/ | ||
| (function() { |
There was a problem hiding this comment.
This needs to be executed post content dom is loaded. And this will not work in repeatable panel case, as content is added dynamically
So I would have declared a static function in password view:
function () { if (passwordInput.type === 'password') { passwordInput.type = 'text'; } else { passwordInput.type = 'password'; } }
Then in setupField register it with the element.
There was a problem hiding this comment.
moved the logic to static function and removed the additional js files.
ui.frontend/src/constants.js
Outdated
| * Html input type text | ||
| * @type {string} | ||
| */ | ||
| HTML_INPUT_TYPE_TEXT : "text", |
There was a problem hiding this comment.
don't add constants here, you can keep them in view
There was a problem hiding this comment.
removed from constants.js and moved to view.
…ct values on view
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: