Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding character counter to Text input textfield/textarea component #1081

Open
wants to merge 514 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
514 commits
Select commit Hold shift + click to select a range
2b00e4d
Revert "override the inplace editing Edit element query."
AnurudraS Sep 5, 2023
21cde69
FORMS-10718 GuideBridge resolveNode API (#858)
rismehta Sep 6, 2023
8acc75f
test cases for custom submit action with redirect parameters (#847)
rismehta Sep 6, 2023
ac60e87
Forms 9492: removing validationExpression empty string from the jso…
s1mahanty Sep 6, 2023
085e6e0
[FORMS-10586] update html structure for RTL (#844)
amit-mnnit Sep 8, 2023
889a471
FORMS-10259 - Custom properties - Refactor code to new design alignin…
TalmizAhmed Sep 11, 2023
2337585
@releng: fixing client library compilation issue (#865)
rismehta Sep 11, 2023
62430be
Revert "Revert "Fix inputted date not reflecting in calendar (#856)""
rismehta Sep 11, 2023
0bb473d
Merge pull request #867 from adobe/devToMaster1109
rismehta Sep 11, 2023
673c434
@releng [maven-scm] :prepare release core-forms-components-reactor-2.…
rismehta Sep 11, 2023
b4c86b6
@releng [maven-scm] :prepare for next development iteration
rismehta Sep 11, 2023
2537a79
Update README.md
rismehta Sep 12, 2023
f9a0b80
Update VERSIONS.md
rismehta Sep 12, 2023
0e7ad4d
Merging dev to master.
sakshi-arora1 Sep 15, 2023
ad40c16
override the inplace editing Edit element query.
AnurudraS Aug 29, 2023
6393c43
Revert "Fix inputted date not reflecting in calendar (#856)"
AnurudraS Sep 5, 2023
732680e
Revert "override the inplace editing Edit element query."
AnurudraS Sep 5, 2023
0c1ab18
Conditional specification validation during PR build (#872)
rismehta Sep 12, 2023
17bab3b
Optimizing test run (#873)
rismehta Sep 13, 2023
f1290d2
Releng moving to latest cloud ready quickstart (#874)
rismehta Sep 14, 2023
aa297b7
Merge branch 'devToMaster' of https://github.com/adobe/aem-core-forms…
sakshi-arora1 Sep 18, 2023
b6759bc
Re-adding Fix inputted date not reflecting in calendar (#856)
sakshi-arora1 Sep 18, 2023
c589f3f
Removing sync PR.
sakshi-arora1 Sep 18, 2023
df7962b
Merge pull request #877 from adobe/devToMaster
sakshi-arora1 Sep 18, 2023
1c9d73b
Adding sync PR step back.
sakshi-arora1 Sep 18, 2023
09df3a7
Merge pull request #898 from adobe/dev-master-28
rismehta Sep 29, 2023
3bf7da4
@releng [maven-scm] :prepare release core-forms-components-reactor-2.…
sakshi-arora1 Sep 29, 2023
2216f1d
@releng [maven-scm] :prepare for next development iteration
sakshi-arora1 Sep 29, 2023
aaa0e82
Update af-core version (#900)
ravise5 Oct 3, 2023
8b30f3b
Merge pull request #902 from adobe/dev2Master
rismehta Oct 4, 2023
2f42ece
@releng [maven-scm] :prepare release core-forms-components-reactor-2.…
Oct 4, 2023
d8582a5
@releng [maven-scm] :prepare for next development iteration
Oct 4, 2023
a691188
Update README.md
rismehta Oct 4, 2023
d82c48a
Update VERSIONS.md
rismehta Oct 4, 2023
b033ae8
Fixing versions.md script (#906)
rismehta Oct 4, 2023
f36a80e
FORMS-11162 - Accessibility Issue - Forms iframe head tag issue (#907)
pankaj-parashar Oct 5, 2023
bb75aa9
FORMS-3696 adding rich text support for labels (#904)
im-shiv Oct 6, 2023
4ca06a5
fix multiple form embedded issue in site page (#909)
amit-mnnit Oct 9, 2023
6211ea7
FORMS-11284 fixing enum name display on hide (#911)
im-shiv Oct 9, 2023
153bb51
Terms and Conditions Component (#889)
barshat7 Oct 10, 2023
5b6b623
use wcm image for integration testing (#917)
barshat7 Oct 10, 2023
06a45eb
FORMS-11340 adding locale test case for rich text (#918)
im-shiv Oct 11, 2023
1698e4e
Terms and Conditions: string change in edit dialog (#919)
barshat7 Oct 11, 2023
edb58a8
Forms 7896 switch component2 (#878)
egmox Oct 11, 2023
329470f
FORMS-10078: updated default pattern to align with v1 (#820)
egmox Oct 11, 2023
5673b3f
FORMS-10978 - Support for Qualified name in core components (#901)
TalmizAhmed Oct 12, 2023
5acedfe
FORMS-11128 Localized Add Item string (#923)
girotraapankaj Oct 13, 2023
6a0d76f
Example Canvas Themes for CheckbBox and TermsAndConditions
Oct 13, 2023
0df92b5
Forms-11276 : Text component does not appear in the viewport when the…
AnurudraS Oct 13, 2023
decce62
unhide checkbox, termsandconditions, switch (#927)
barshat7 Oct 13, 2023
4fd7884
Merge pull request #928 from adobe/adobe/devToMaster
rismehta Oct 16, 2023
7cb0512
@releng [maven-scm] :prepare release core-forms-components-reactor-2.…
Oct 16, 2023
5178163
@releng [maven-scm] :prepare for next development iteration
Oct 16, 2023
83db0b4
Update VERSIONS.md and README.md to include version 2.0.62
Oct 16, 2023
6d3891c
Revert "Adobe/dev to master"
barshat7 Oct 25, 2023
4102846
Merge pull request #945 from adobe/revert-928-adobe/devToMaster
barshat7 Oct 25, 2023
34745a3
Merge branch 'master' into adobe/devToMaster
barshat7 Oct 25, 2023
cf28b4a
Merge pull request #951 from adobe/adobe/devToMaster
rismehta Oct 25, 2023
0a0af40
tnc fix for approval checkbox not getting sent in submission (#953)
barshat7 Oct 26, 2023
6420043
Merge pull request #954 from adobe/adobe/devToMaster
rismehta Oct 26, 2023
e7c0f94
@releng [maven-scm] :prepare release core-forms-components-reactor-2.…
Oct 26, 2023
a00b189
@releng [maven-scm] :prepare for next development iteration
Oct 26, 2023
11c266b
Update VERSIONS.md and README.md to include version 2.0.64
Oct 26, 2023
ddc4a05
Rte revert (#968)
barshat7 Nov 2, 2023
202ce83
Merge pull request #972 from adobe/dev-to-master-02-11-23
barshat7 Nov 2, 2023
8537778
@releng [maven-scm] :prepare release core-forms-components-reactor-2.…
barshat7 Nov 2, 2023
38b3632
@releng [maven-scm] :prepare for next development iteration
barshat7 Nov 2, 2023
0bc19f0
Update VERSIONS.md and README.md to include version 2.0.66
Nov 2, 2023
3bbcab8
Adding support to handle sites page language in form container (#976)
rismehta Nov 2, 2023
9194b6a
Merge pull request #979 from adobe/dev_to_master_3_11
rismehta Nov 2, 2023
d03fefe
@releng [maven-scm] :prepare release core-forms-components-reactor-2.…
rismehta Nov 2, 2023
b98b18b
@releng [maven-scm] :prepare for next development iteration
rismehta Nov 2, 2023
f6397bc
Update VERSIONS.md and README.md to include version 2.0.68
Nov 2, 2023
8a7fa0d
[FORMS-11514]: Update help links (#963)
s1mahanty Nov 2, 2023
f27ef30
Updating submission error sample (#981)
rismehta Nov 4, 2023
79aae63
@releng moving to latest aem image (#982)
rismehta Nov 6, 2023
0332753
Merge pull request #983 from adobe/dev-master-06-11
rismehta Nov 6, 2023
445c9a5
@releng [maven-scm] :prepare release core-forms-components-reactor-2.…
rismehta Nov 6, 2023
3d5660f
@releng [maven-scm] :prepare for next development iteration
rismehta Nov 6, 2023
481c325
Update VERSIONS.md and README.md to include version 2.0.70
Nov 6, 2023
e934413
Merge remote-tracking branch 'adobe/dev' into dev-master-0611
rismehta Nov 6, 2023
3c16b4b
Merge pull request #987 from adobe/dev_master
rismehta Nov 6, 2023
8256fea
@releng [maven-scm] :prepare release core-forms-components-reactor-2.…
rismehta Nov 6, 2023
1b6c861
@releng [maven-scm] :prepare for next development iteration
rismehta Nov 6, 2023
56f7e00
updating version and readme
rismehta Nov 6, 2023
47ace60
@releng [maven-scm] :prepare release core-forms-components-reactor-2.…
rismehta Nov 6, 2023
b4c7939
@releng [maven-scm] :prepare for next development iteration
rismehta Nov 6, 2023
06405e5
Update VERSIONS.md and README.md to include version 2.0.74
Nov 6, 2023
2f1d0d3
resolved conflict in datepickerview
Dec 4, 2023
b75f18d
Merge pull request #1006 from adobe/dgurjarMaster
rismehta Dec 5, 2023
57470fb
@releng [maven-scm] :prepare release core-forms-components-reactor-2.…
rismehta Dec 5, 2023
3da4062
@releng [maven-scm] :prepare for next development iteration
rismehta Dec 5, 2023
63860c9
Update README.md
rismehta Dec 5, 2023
d747f69
Update VERSIONS.md
rismehta Dec 5, 2023
03a2c7e
Update README.md
rismehta Dec 19, 2023
83e64f6
Update README.md
rismehta Dec 8, 2023
4a4ac39
fixed default value for date not showing in authoring (#967)
egmox Dec 12, 2023
0ea9c98
fixed css for replace dialog to prevent overlaping clear button with …
egmox Dec 12, 2023
f45756b
Added updateEnum and updateEnumNames methods for radio, checkbox and …
ravise5 Dec 12, 2023
8b6822c
Added Test Case for Document of Record generation (#1007)
barshat7 Dec 12, 2023
50467cc
Add autocomplete attribute on input and fix placeholder property. (#955)
dmaurya929 Dec 12, 2023
f85bdaf
changed direction attribute for fillable fields
Oct 31, 2023
82ad244
Added support of dir on container
Dec 18, 2023
c1f9f64
rtl date input fixes
rajatkhurana-adobe Dec 19, 2023
79d10c0
Merge pull request #1024 from adobe/localMaster
sakshi-arora1 Dec 19, 2023
5bcd97a
merged master to dev of 22nd Jan
Jan 22, 2024
836686a
merged master to dev.........
Jan 22, 2024
2a492b1
Merge pull request #1043 from adobe/dev_22Jan
deepprakash345 Jan 22, 2024
96de53a
@releng [maven-scm] :prepare release core-forms-components-reactor-2.…
Jan 22, 2024
c6c05d0
@releng [maven-scm] :prepare for next development iteration
Jan 22, 2024
235355d
Update README.md
rismehta Jan 23, 2024
ff38864
Update VERSIONS.md
rismehta Jan 23, 2024
97ae8d3
Merge branch 'dev' of https://github.com/adobe/aem-core-forms-compone…
Jan 23, 2024
e20aa1b
Merge pull request #1045 from adobe/dev_23Jan
barshat7 Jan 23, 2024
2a51a94
@releng [maven-scm] :prepare release core-forms-components-reactor-2.…
Jan 23, 2024
32a5943
@releng [maven-scm] :prepare for next development iteration
Jan 23, 2024
4ee8fbd
Update README.md
rismehta Jan 23, 2024
0d19b37
Update VERSIONS.md
rismehta Jan 23, 2024
0507008
Adding atleast once guarantee while creating github release notes (#1…
rismehta Jan 23, 2024
5748651
@releng [maven-scm] :prepare release core-forms-components-reactor-2.…
rismehta Jan 24, 2024
fb63127
@releng [maven-scm] :prepare for next development iteration
rismehta Jan 24, 2024
c04bd85
Adding more logs
rismehta Jan 24, 2024
9a0aeaa
@releng [maven-scm] :prepare release core-forms-components-reactor-2.…
rismehta Jan 24, 2024
b1c5c7b
@releng [maven-scm] :prepare for next development iteration
rismehta Jan 24, 2024
95a7d3d
Update README.md
rismehta Jan 25, 2024
204c2c4
Update VERSIONS.md
rismehta Jan 25, 2024
ce2db60
@releng [maven-scm] :prepare release core-forms-components-reactor-2.…
rismehta Jan 25, 2024
e7d0363
@releng [maven-scm] :prepare for next development iteration
rismehta Jan 25, 2024
4c6eab5
Update README.md
rismehta Jan 25, 2024
1f2c288
Update VERSIONS.md
rismehta Jan 25, 2024
436594e
Adding debugging output in circle ci for easy issue disovery in future
rismehta Jan 25, 2024
127f0ee
Update README.md
rismehta Jan 31, 2024
9faabb5
Hide layout field for tabs/wizard/accordion in edit dialog (#915)
dmaurya929 Jan 23, 2024
c04b276
file input highlight drop area (#1048)
rajatofficial Jan 24, 2024
11efa62
Support for versioning and annotation
barshat7 Nov 20, 2023
9d99500
Support for versioning in all containers
barshat7 Nov 21, 2023
20b9784
Disable wizard naviation validation in Author mode
barshat7 Dec 15, 2023
92ec8b9
FORMS-11541 : update af-core version for passing form, field and even…
arunattri26 Jan 30, 2024
9c531fd
updated test (#1021)
egmox Jan 30, 2024
210dd66
FORMS-12807 | ReCaptcha fix for form embed in sites
Jan 29, 2024
7b47ad4
FORMS-12679: Strings is unlocalized in "Search and Lister" Component …
mayankjindalmj Jan 30, 2024
29df65c
FORMS-12557 Forms run enhancements (#1033)
rismehta Jan 30, 2024
f72b5d5
Merge pull request #1058 from adobe/dev-to-master-1-feb-24
rismehta Feb 2, 2024
4a10c34
Updating aem base image version (#1063)
rismehta Feb 5, 2024
1a550a3
Merge pull request #1064 from adobe/dev-to-master-6-Feb
rismehta Feb 6, 2024
b82d86a
@releng [maven-scm] :prepare release core-forms-components-reactor-2.…
barshat7 Feb 6, 2024
3a7851b
@releng [maven-scm] :prepare for next development iteration
barshat7 Feb 6, 2024
2502e28
Update README.md
rismehta Feb 6, 2024
8dad4ac
Update VERSIONS.md
rismehta Feb 6, 2024
75972ad
Merge branch 'master' into dev-to-master-14-Feb
girotraapankaj Feb 14, 2024
e6d9709
Merge pull request #1075 from adobe/dev-to-master-14-Feb
barshat7 Feb 15, 2024
467fbc9
@releng [maven-scm] :prepare release core-forms-components-reactor-2.…
Feb 16, 2024
daebbbe
@releng [maven-scm] :prepare for next development iteration
Feb 16, 2024
c85c19f
Update README.md
rismehta Feb 20, 2024
5d245d5
Update VERSIONS.md
rismehta Feb 20, 2024
e5a03fe
Adding character counter to Text input textfield/textarea component
shubham-adobeaem Feb 21, 2024
427563e
Addressing PR comments
shubham-adobeaem Feb 29, 2024
9d59062
Merge branch 'master' into dev-to-master-6-March-2024
barshat7 Mar 6, 2024
33648d1
Merge pull request #1115 from adobe/dev-to-master-6-March-2024
rismehta Mar 7, 2024
394cc4f
@releng [maven-scm] :prepare release core-forms-components-reactor-3.0.0
barshat7 Mar 7, 2024
f5da9f9
@releng [maven-scm] :prepare for next development iteration
barshat7 Mar 7, 2024
3860224
updating version/readme
rismehta Mar 7, 2024
56a17aa
Adding Junits
shubham-adobeaem Mar 18, 2024
7ec4d30
FORMS-13392 Role main check (#1112)
rajatofficial Mar 11, 2024
b552c9d
Constraint messages should work when type is integer for number-input…
ravise5 Mar 18, 2024
a60c0a1
Revert "Rich text support (#1077)" (#1129)
rismehta Mar 18, 2024
ea5bc19
Merge pull request #1130 from adobe/devMaster1803
rismehta Mar 18, 2024
f3a9e36
@releng [maven-scm] :prepare release core-forms-components-reactor-3.0.2
rismehta Mar 18, 2024
6ecacf3
@releng [maven-scm] :prepare for next development iteration
rismehta Mar 18, 2024
5318820
Update VERSIONS.md
rismehta Mar 18, 2024
03cb6b8
Update README.md
rismehta Mar 18, 2024
ac1f567
Adding debug log to print git version
rismehta Mar 18, 2024
ce5ea5e
Revert "Revert "Rich text support (#1077)"" (#1131)
im-shiv Mar 20, 2024
f17ec3a
FORMS-11692: upgraded af2-web-runtime version and added rule editor t…
arunattri26 Mar 21, 2024
1a8688f
RTC Add support for displayValueExpression (#1126)
ravise5 Mar 22, 2024
b0f07e5
Merge pull request #1141 from adobe/dev2master26March
rismehta Mar 26, 2024
6ae3e38
@releng [maven-scm] :prepare release core-forms-components-reactor-3.0.4
Mar 26, 2024
06109ba
@releng [maven-scm] :prepare for next development iteration
Mar 26, 2024
5d5cf47
Update README.md
Mar 26, 2024
d8d58f5
Update version in ReadMe
Mar 26, 2024
681833e
Revert "Update README.md"
rismehta Mar 26, 2024
a66d993
Revert "Update version in ReadMe"
rismehta Mar 26, 2024
9eccd28
Fixing circle ci script and updating version.md and release/md
rismehta Mar 27, 2024
15251a6
Revert "Merge pull request #1141 from adobe/dev2master26March"
rismehta Mar 27, 2024
44dc04a
Revert "Merge pull request #1130 from adobe/devMaster1803"
rismehta Mar 27, 2024
463d31f
Merge branch 'dev' into devM27March
rismehta Mar 27, 2024
b952b6e
Aligning command.js to dev
rismehta Mar 27, 2024
d6fbfd0
Merge branch 'dev' into devM27March
rismehta Mar 27, 2024
ceb4af9
Merge branch 'dev' into devM27March
rismehta Mar 27, 2024
2144380
Merge pull request #1147 from adobe/devM27March
rismehta Mar 27, 2024
c7aa6a7
@releng [maven-scm] :prepare release core-forms-components-reactor-3.0.6
rismehta Mar 27, 2024
fff0683
@releng [maven-scm] :prepare for next development iteration
rismehta Mar 27, 2024
e4205a9
Update VERSIONS.md and README.md to include version 3.0.6
Mar 27, 2024
b77baa7
FORMS-13753 Fixing regression related to dataRef parameter (#1155)
rismehta Apr 2, 2024
7f22a2e
disable exposing view layer for customization (#1156)
barshat7 Apr 2, 2024
2432c3f
FORMS-13484: Update the help link for Embed (v2) (#1154)
s1mahanty Apr 3, 2024
3942e02
Invalid event customization (#1157)
rismehta Apr 3, 2024
ee7fbea
CQ-4348557 adding another div to stop footer getting resized (#1122)
im-shiv Apr 3, 2024
e19cbc7
Merge pull request #1159 from adobe/dev-to-master-03-apr-2024
barshat7 Apr 4, 2024
7991d8f
@releng [maven-scm] :prepare release core-forms-components-reactor-3.0.8
barshat7 Apr 4, 2024
8e71f29
@releng [maven-scm] :prepare for next development iteration
barshat7 Apr 4, 2024
404540d
Update VERSIONS.md and README.md to include version 3.0.8
Apr 4, 2024
465ed81
FORMS-13810: Add the field to allow custom message for format in date…
s1mahanty Apr 4, 2024
51f4ea2
FORMS-13829 Drop Down View not getting updated, even if model is upda…
sakshi-arora1 Apr 4, 2024
11f662b
fixed issue for Persian language (#1162)
devgurjar Apr 4, 2024
9e45e75
Merge pull request #1166 from adobe/devToMaster4April
sakshi-arora1 Apr 5, 2024
1f19bd4
Added Aria Invalid attribute (#1149)
pavi41 Apr 9, 2024
ef5335e
Merge pull request #1177 from adobe/devtomaster09-April
rismehta Apr 9, 2024
cf215a2
@releng [maven-scm] :prepare release core-forms-components-reactor-3.…
barshat7 Apr 10, 2024
e88c6bf
@releng [maven-scm] :prepare for next development iteration
barshat7 Apr 10, 2024
ac6f9b7
Update VERSIONS.md and README.md to include version 3.0.10
Apr 10, 2024
41e891e
FORMS-13871 text shouldn't show checkbox for rich text title (#1173)
im-shiv Apr 10, 2024
67bfdf4
datepicker readonly does not work when edit or display format set (#1…
barshat7 Apr 10, 2024
ae88d9f
FORMS-12667 Update type property on replacing checkboxgroup to radio …
dmaurya929 Apr 10, 2024
c289f0c
FORMS-13760 Date picker display value not working during prefill (#1180)
rismehta Apr 10, 2024
05f1e31
Move core component to 0.13.0 spec version (#1181)
rismehta Apr 11, 2024
b9c6fa3
datepicker timezone issue on view layer fixed (#1168)
barshat7 Apr 11, 2024
bd0aab0
Merge pull request #1183 from adobe/devToMaster11Apr
rismehta Apr 12, 2024
510d021
@releng [maven-scm] :prepare release core-forms-components-reactor-3.…
barshat7 Apr 12, 2024
f0b5391
@releng [maven-scm] :prepare for next development iteration
barshat7 Apr 12, 2024
cfac452
Update VERSIONS.md and README.md to include version 3.0.12
Apr 12, 2024
a36ceeb
Merge pull request #1187 from adobe/devtomaster-15Apr
rismehta Apr 15, 2024
ccb2daf
@releng [maven-scm] :prepare release core-forms-components-reactor-3.…
barshat7 Apr 15, 2024
153ca33
@releng [maven-scm] :prepare for next development iteration
barshat7 Apr 15, 2024
4967387
Update VERSIONS.md and README.md to include version 3.0.14
Apr 15, 2024
5c19a65
FORMS-12822 : format should not be visible when no pattern is selecte…
AnurudraS Apr 17, 2024
ab496c7
Revert "FORMS-12822 : format should not be visible when no pattern is…
rismehta Apr 17, 2024
fa4651c
Added condition on description and error message in aria-describedby
Apr 16, 2024
c58343d
FORMS-12203: Added localization changes and test cases (#1152)
shivangimittal791 Apr 17, 2024
f0f6fae
FORMS-13851 Support for language in date picker and number input (#1169)
rismehta Apr 18, 2024
ad0490c
Merge pull request #1197 from adobe/devtomaster-18Apr
rismehta Apr 18, 2024
ad4f690
@releng [maven-scm] :prepare release core-forms-components-reactor-3.…
barshat7 Apr 19, 2024
d825c78
@releng [maven-scm] :prepare for next development iteration
barshat7 Apr 19, 2024
7f470d9
Update VERSIONS.md and README.md to include version 3.0.16
Apr 19, 2024
95b4549
Merge branch 'master' into feature/text-input-character-counter
shubham-adobeaem Apr 24, 2024
089ec60
merge conflicts
shubham-adobeaem Apr 24, 2024
37bcd1d
Merge branch 'dev' into feature/text-input-character-counter
shubham-adobeaem Apr 24, 2024
cffd65f
Revert "merge conflicts"
shubham-adobeaem Apr 24, 2024
23a3ed1
merge conflicts
shubham-adobeaem Apr 24, 2024
78dbcf7
merge conflicts
shubham-adobeaem Apr 24, 2024
c70e6b8
merge conflicts
shubham-adobeaem Apr 24, 2024
e770ddf
Merge remote-tracking branch 'upstream/dev' into feature/text-input-c…
shubham-adobeaem May 1, 2024
90e89e9
Updated
shubham-adobeaem May 1, 2024
5b16fb3
fromatted
shubham-adobeaem May 1, 2024
4726a38
fromatted
shubham-adobeaem May 1, 2024
41c53c0
fromatted
shubham-adobeaem May 1, 2024
4269c73
Revert
shubham-adobeaem May 1, 2024
bac2502
Revert
shubham-adobeaem May 1, 2024
a367389
Revert
shubham-adobeaem May 1, 2024
0a40f26
Localisiing
shubham-adobeaem May 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -56,6 +56,10 @@ public class TextInputImpl extends AbstractFieldImpl implements TextInput {
@Nullable
protected String format;

@ValueMapValue(injectionStrategy = InjectionStrategy.OPTIONAL)
@Default(booleanValues = false)
protected boolean showCharCounter;

@ValueMapValue(injectionStrategy = InjectionStrategy.OPTIONAL, name = "pattern")
@Nullable
protected String pattern;
Expand All @@ -74,6 +78,11 @@ public boolean isMultiLine() {
return multiLine;
}

@Override
public boolean showCharCounter() {
return showCharCounter;
}

@Override
public String getFieldType() {
if (isMultiLine()) {
Expand Down
Expand Up @@ -66,4 +66,14 @@ default String getFormat() {
return null;
}

/**
* Returns {@code true} if character counter needs to be shown, otherwise {@code false}.
*
* @return {@code true} if character counter needs to be shown, otherwise {@code false}
* @since com.adobe.cq.forms.core.components.models.form 0.0.1
*/
@JsonIgnore
default boolean showCharCounter() {
return false;
}
}
Expand Up @@ -231,6 +231,15 @@ void testIsMultiLine() {
assertEquals(false, textInputMock.isMultiLine());
}

@Test
void testShowCharCounter() {
TextInput textInput = Utils.getComponentUnderTest(PATH_TEXTINPUT_CUSTOMIZED, TextInput.class, context);
assertEquals(true, textInput.showCharCounter());
TextInput textInputMock = Mockito.mock(TextInput.class);
Mockito.when(textInputMock.showCharCounter()).thenCallRealMethod();
assertEquals(false, textInputMock.showCharCounter());
}

@Test
void testGetPlaceHolder() {
TextInput textInput = Utils.getComponentUnderTest(PATH_TEXTINPUT_CUSTOMIZED, TextInput.class, context);
Expand Down
Expand Up @@ -10,6 +10,7 @@
"jcr:primaryType": "nt:unstructured",
"sling:resourceType" : "core/fd/components/form/textinput/v1/textinput",
"name" : "abc",
"showCharCounter" : true,
"jcr:title" : "def",
"hideTitle" : false,
"dorExclusion": true,
Expand Down Expand Up @@ -73,6 +74,7 @@
"sling:resourceType" : "core/fd/components/form/textinput/v1/textinput",
"name" : "abc",
"multiLine" : true,
"showCharCounter" : true,
"fieldType": "multiline-input",
"jcr:title" : "def",
"hideTitle" : false,
Expand Down
@@ -0,0 +1,6 @@
<template data-sly-template.characterCounter="${@ componentId, showCharCounter, maxLength, bemBlock}">
<div data-sly-test="${showCharCounter}" class="${bemBlock}__charcounter" aria-label="Character Counter">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localize these like:
${'Character Counter' @ i18n, locale=request.locale}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly localize:

  1. Current Character Count
  2. Maximum Character Count

<span class="${bemBlock}__charcount" aria-label="Current Character Count"></span>
<span data-sly-test="${maxLength}" class="${bemBlock}__maxchar" aria-label="Maximum Character Count">/${maxLength @ i18n, locale=request.locale}</span>
</div>
</template>
Expand Up @@ -56,6 +56,9 @@ BLOCK cmp-adaptiveform-textinput
ELEMENT cmp-adaptiveform-textinput__label
ELEMENT cmp-adaptiveform-textinput__label-container
ELEMENT cmp-adaptiveform-textinput__widget
ELEMENT cmp-adaptiveform-textinput__charcounter
ELEMENT cmp-adaptiveform-textinput__charcount
shubham-adobeaem marked this conversation as resolved.
Show resolved Hide resolved
ELEMENT cmp-adaptiveform-textinput__maxchar
ELEMENT cmp-adaptiveform-textinput__questionmark
ELEMENT cmp-adaptiveform-textinput__shortdescription
ELEMENT cmp-adaptiveform-textinput__longdescription
Expand Down
Expand Up @@ -221,6 +221,14 @@
fieldLabel="Maximum Number of characters"
min="0"
name="./maxLength"/>
<showCharCounter
jcr:primaryType="nt:unstructured"
sling:resourceType="granite/ui/components/coral/foundation/form/checkbox"
checked="{Boolean}false"
fieldLabel="Show Character Counter?"
name="./showCharCounter"
text="Show Character Counter?"
value="true"/>
<maxLengthMessage
jcr:primaryType="nt:unstructured"
sling:resourceType="granite/ui/components/coral/foundation/form/textarea"
Expand Down
Expand Up @@ -41,3 +41,7 @@ textarea.cmp-adaptiveform-textinput__widget{
.cmp-adaptiveform-textinput__questionmark {

}
.cmp-adaptiveform-textinput__charcounter {
shubham-adobeaem marked this conversation as resolved.
Show resolved Hide resolved
}
.cmp-adaptiveform-textinput__charcount {
}
Expand Up @@ -34,7 +34,8 @@
description: `.${TextInput.bemBlock}__longdescription`,
qm: `.${TextInput.bemBlock}__questionmark`,
errorDiv: `.${TextInput.bemBlock}__errormessage`,
tooltipDiv: `.${TextInput.bemBlock}__shortdescription`
tooltipDiv: `.${TextInput.bemBlock}__shortdescription`,
counterSpan: `.${TextInput.bemBlock}__charcount`
};

constructor(params) {
Expand Down Expand Up @@ -64,6 +65,9 @@
getQuestionMarkDiv() {
return this.element.querySelector(TextInput.selectors.qm);
}
getCounterSpan() {
return this.element.querySelector(TextInput.selectors.counterSpan);
}

setModel(model) {
super.setModel(model);
Expand All @@ -79,6 +83,19 @@
this.setActive();
this.setWidgetValueToModelValue();
});
this.setupCharacterCounter();
}

setupCharacterCounter() {
const counterSpan = this.getCounterSpan();
const updateCharacterCounter = () => {
const charCount = this.widget.value.length;
if (counterSpan) {
counterSpan.textContent = Granite.I18n.getMessage(charCount);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also do the same for max character count, as authour can write a rule to modify that and then the modified value should show up and also will need to be localized.

};
this.widget.addEventListener('input', updateCharacterCounter);
updateCharacterCounter(); // Set the initial character count
}
}

Expand Down
Expand Up @@ -19,6 +19,7 @@
data-sly-use.clientlib="${'/libs/granite/sightly/templates/clientlib.html'}"
data-sly-use.label="${renderer.labelPath}"
data-sly-use.shortDescription="${renderer.shortDescriptionPath}"
data-sly-use.characterCounter="${renderer.characterCounterPath}"
data-sly-use.longDescription="${renderer.longDescriptionPath}"
data-sly-use.errorMessage="${renderer.errorMessagePath}"
data-sly-use.questionMark="${renderer.questionMarkPath}"></sly>
Expand Down Expand Up @@ -65,6 +66,7 @@
minlength="${text.minLength}"
maxlength="${text.maxLength}"
dir="auto"/>
<div data-sly-call="${characterCounter.characterCounter @componentId=text.id, showCharCounter=text.showCharCounter, maxLength=text.maxLength, bemBlock='cmp-adaptiveform-textinput'}" data-sly-unwrap></div>
<div data-sly-call="${shortDescription.shortDescription @componentId=text.id, shortDescriptionVisible=text.tooltipVisible, shortDescription=text.tooltip, bemBlock='cmp-adaptiveform-textinput'}" data-sly-unwrap>
</div>
<div data-sly-call="${longDescription.longDescription @componentId=text.id, longDescription=text.description, bemBlock='cmp-adaptiveform-textinput'}" data-sly-unwrap></div>
Expand Down
Expand Up @@ -22,13 +22,15 @@ use(function () {
var longDescriptionPath = "core/fd/components/af-commons/v1/fieldTemplates/longDescription.html";
var questionMarkPath = "core/fd/components/af-commons/v1/fieldTemplates/questionMark.html"
var errorMessagePath = "core/fd/components/af-commons/v1/fieldTemplates/errorMessage.html";
var characterCounterPath = "core/fd/components/af-commons/v1/fieldTemplates/characterCounter.html";

return {
labelPath: labelPath,
shortDescriptionPath: shortDescriptionPath,
longDescriptionPath: longDescriptionPath,
questionMarkPath: questionMarkPath,
errorMessagePath: errorMessagePath,
characterCounterPath: characterCounterPath,
clientlibs: clientlibsArr
}
});
Expand Up @@ -50,6 +50,8 @@ describe('Page - Authoring', function () {
// Check If Dialog Options Are Visible
cy.get("[name='./multiLine']")
.should("exist");
cy.get("[name='./showCharCounter']")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add test if the input is updated, count is also updated.

.should("exist");
cy.get("[name='./autocomplete']")
.should("exist");

Expand Down