FORMS-12148 ensuring different radio button group elements have diffe… #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rismehta
reviewed
Dec 15, 2023
| @@ -43,7 +43,7 @@ | |||
| <label class="cmp-adaptiveform-radiobutton__option-label" | |||
| title="${radioButton.tooltipVisible ? '' : radioButton.tooltipText}"> | |||
| <input type="radio" | |||
| name="${radioButton.name}" | |||
| name="${radioButton.id}" | |||
There was a problem hiding this comment.
Test cases are failing due to this change, shouldn't name be the radio button's name ? Can you also add repeatable test case in the existing repeatable test suite ?
There was a problem hiding this comment.
No. Different radio button in the same group should have same names but not across the different groups.
Radio Button Groups can have same name across panels/repeating panels, hence we should use id since id is unique for different groups
|
@vdua merge is direct into master shouldn't it be dev first? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rent name
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: