Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing uploads after EOL detection refactoring #1860

Merged
merged 7 commits into from
May 12, 2024
Merged

Fix failing uploads after EOL detection refactoring #1860

merged 7 commits into from
May 12, 2024

Conversation

afranken
Copy link
Member

@afranken afranken commented May 10, 2024 •
edited

Description

  • Fix failing uploads after EOL detection refactoring
    • Known issue: using HTTP, AWS SDKv2 sends the wrong checksum for SHA256, leading uploads to fail
  • Adding a lots of additional tests for combinations of HTTP / HTTPS and sync / async clients

Related Issue

#1840
#1842
#1818

Tasks

  • I have signed the CLA.
  • I have written tests and verified that they fail without my change.

@afranken
Allow tests with HTTP and multiple files
65676e4
@afranken
Revert checksum decoding streams refactoring
0528566 
The refactoring with modified EOL detection lead to failing uploads
in many scenarios. Unfortunately, this will lead to async chunked
uploads to fail again. See #1818

Fixes #1840
Fixes #1842
@afranken
Kotlinify test
f65b922
@afranken
Skip multiple CRLF if present.
adb47e0 
For unknown reasons, when using the async clients to upload chunked
data, the SDK sometimes inserts multiple CRLFs between chunks.
Skip if we need to.

Fixes #1840
Fixes #1842
@afranken afranken force-pushed the 1840-1842-fix-signed-chunked-uploads branch from ae809de to 4b679ee Compare May 12, 2024 10:33
@afranken
More tests with different files, sync/async and http/https
6cb76c7 
For unknown reasons, the AWS Java SDKv2 sends the wrong checksum for
SHA256 when using HTTP. Skip this test for now.

Fixes #1840
Fixes #1842
@afranken afranken force-pushed the 1840-1842-fix-signed-chunked-uploads branch from 4b679ee to 6cb76c7 Compare May 12, 2024 10:34
@afranken afranken self-assigned this May 12, 2024
@afranken afranken added the bug label May 12, 2024
@afranken afranken changed the title 1840 1842 fix signed chunked uploads Fix failing uploads after EOL detection refactoring May 12, 2024
@afranken afranken merged commit 4ec4cfd into main May 12, 2024
6 checks passed
@afranken afranken deleted the 1840-1842-fix-signed-chunked-uploads branch May 12, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@afranken afranken

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@afranken