-
-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Unflag custom reports #2554
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
I think I'm ready to remove custom reports from experimental. It's fairly stable at this point. It has most everything I planned to add to it. Still plenty more to add and a couple things to fix but I don't think they are big issues that should stop it from going "live". Please share your thoughts. |
I think my main hangup would be that live date ranges don't update for dashboard cards without going in and updating the report. Its not a big deal since work will still go on. |
Yea, it's at the top of my list right now. I'll try to put in a PR this weekend to fix that. |
I'd recommend not rushing into this prematurely. The feature still seems quite unstable (judging from the amount of bug reports coming in). Could we hold off a bit more to gather some more feedback before calling it a stable feature? |
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Heya, I know this comment is 2 months old but the bug reports you mention were very small issues that were directly related to newer features and were fixed quite easily. The only reason I said stable is that we've gone several months without any major issues with the feature. Fast forward to today - since opening this PR, I've requested feedback on the stability of the feature and fixed all (very minor, most visual) issues reported. I've also converted 100% of the code to strict TS and submitted several code hardening PRs to make this feature ready for release. If there are any further concerns I'm happy to address them. I am currently very confident in propsing this feature is removed from experimental for the next release (v24.7). |
Sounds like a good plan! |
Removing custom reports from feature flag "experimental" state.