Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It should be possible to specify multiple new has_many record links #5367

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

faucct
Copy link
Contributor

@faucct faucct commented Mar 5, 2018

No description provided.

@faucct faucct force-pushed the feature/multiple_add_has_many_links branch from dd2f934 to 4096dce Compare March 5, 2018 10:56
@codecov
Copy link

codecov bot commented Mar 5, 2018

Codecov Report

Merging #5367 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5367      +/-   ##
==========================================
+ Coverage   98.32%   98.33%   +<.01%     
==========================================
  Files         294      294              
  Lines       11015    11036      +21     
==========================================
+ Hits        10831    10852      +21     
  Misses        184      184
Impacted Files Coverage Δ
lib/active_admin/form_builder.rb 100% <100%> (ø) ⬆️
spec/unit/form_builder_spec.rb 99.29% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cedfe5...4096dce. Read the comment docs.

@zorab47
Copy link
Contributor

zorab47 commented Jul 4, 2018

Can you describe the use case and provide more background on this change?

@faucct
Copy link
Contributor Author

faucct commented Jul 5, 2018

We use this feature to make it possible to create STI records: instead of exposing #type select input each subclass has its own "Add record" link with a customized form which could have more or less inputs. Persisted records also get customized forms.
Here is another usecase – #5309

@activeadmin activeadmin deleted a comment from faucct Mar 13, 2023
@activeadmin activeadmin deleted a comment from faucct Mar 13, 2023
@activeadmin activeadmin deleted a comment from faucct Mar 13, 2023
@activeadmin activeadmin deleted a comment from faucct Mar 13, 2023
@activeadmin activeadmin deleted a comment from faucct Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants