-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support pathname except ssh #1305
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Checked on instance - works.
Any movement on this PR? Really waiting on this feature to complete a new system for work environment. |
Just FYI, I think we can temporally reference this update as follows: steps:
- uses: ischanx/checkout@06c611454073903c9d44641d7e085b21115d3dcf |
@TingluoHuang would you like to have a look on this? |
@megamanics Could we tempt you pretty please? 🙏 💙 |
Successfully tested on a gitea-instance behind a proxy and with subpath |
please add some test cases to demonstrate its usage. |
@ischanx would you please update the merge request or maybe you could grant me or @Reverier-Xu write permission on your fork and so maybe we could finish things up? |
👋 This is not something we currently plan to support - see #1242 (comment) for more info. |
@joshmgross you don't need to plan to support, it's already there |
It's obvious what Micro$oft is trying to do with this. It'll just be up to Gitea, Forgejo, etc to fork actions and prevent actions from requesting GitHub by default and instead use Instance actions. At least that won't be difficult, just a base uri change. |
In some cases pathname is required, but SSH does not support pathname.
close #1242