Skip to content

Fix issues with thermal models
Compare
Choose a tag to compare
@jzuhone jzuhone released this 01 Dec 03:43
· 33 commits to master since this release
2.3.0
4fdceb1
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.

What's Changed

  • The call to get_xija_model_spec in the function find_json to get the model specification file originally set check_version=True, but this function was often called many times in a short interval in some applications and github did not appreciate the repeated requests. So this option is now turned off.
  • The find_json function also had some convoluted logic to look for the JSON file in a different chandra_models repository path which has now been fixed.
  • The ThermalModelFromRun class "divided" a string by a string instead of using the divide operator to concatenate a Path object and a string. This has now been fixed.
  • The ThermalModelRunner.from_backstop had an error in computing the initial temperature from the start of a model run. This has now been fixed, and required an update to one of the test answers.
  • A new pytest fixture has been added to allow one to store new answers when running the tests if necessary.
  • The interface with acis_thermal_check has been updated to match the changes made in acisops/acis_thermal_check#44.
  • The planning limit for 1DEAMZT model was one degree lower than it should have been and this is fixed.

Full Changelog: 2.2.0...2.3.0

Includes the following merges:

  • PR #9: Fix issues with thermal model handling
Assets 2