First version of the 1DPAMYT model and setup.py mods #72
Conversation
|
@Gregg140 can I push up a quick fix to this branch to fix the test failure? It's just a reformatting fix. |
setup.py
Outdated
| author="John ZuHone", | ||
| author_email="john.zuhone@cfa.harvard.edu", | ||
| description="ACIS Thermal Model Library Program for 1DPAMYT", | ||
| author="Gregg Germain", |
There was a problem hiding this comment.
These lines in setup.py are for the whole package. They say me now, but we should probably put this instead:
author="ACIS Ops",
author_email="acisdude@cfa.harvard.edu",There was a problem hiding this comment.
and description="ACIS Thermal Model Library" should stay the same.
|
@Gregg140 - did you consider factoring out the common code into a base class to adhere to the DRY principle? The only functional difference between your new module and the existing one is changing the MSID name, so that MSID could be a base class attribute. |
John Z and I discussed this at length yesterday. John has identified a few places where we should consider a bigger refactor overall. And we agreed that we should put this present version in place for now so that we have it and can start running it sooner rather than later. |
jzuhone
force-pushed
the
New_1DPAMYT_Model
branch
from
b633eb5
to
c1fecf8
Compare
Description
Initial version of a 1DPAMYT model which can be used if the 1DPAMZT sensor fails.
Interface impacts
The 1DPAMYT model will have a calling sequence similar to 1DPAMZT
Testing
Unit tests
Functional tests
Run with several past load weeks. Validation plots provided insight as to the goodness of the fit.