Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LTN cell calculations account for one-way roads #1043

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dabreegster
Copy link
Collaborator

Problem: Sometimes one-ways can effectively block off part of an area:
Screenshot from 2023-01-16 14-58-04
There's just one large purple cell, though, because the current calculation ignores direction of the roads.

This PR is a start to taking them into account:
Screenshot from 2023-01-16 15-00-14

But even this example gets confusing. Why is there the tiny blue cell at the bottom? There are "spurious" changes in cells based on the order we happen to floodfill. For example we have both:
Screenshot from 2023-01-16 15-01-31
and
Screenshot from 2023-01-16 15-02-46

I think this idea has potential, but there are subtleties. A cell is meant to represent everywhere you can reach without leaving the area. One-ways throw that off.

@dabreegster
Copy link
Collaborator Author

Maybe it should be defined per entry into the area? If there's a "loop" like this, if you enter as part of the loop, you're forced out. But if you enter from the other side and join the loop, then it forces you out. Those are different cases. And maybe all the shortcutting traffic is trying to enter from one boundary road, and the other isn't a real problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant