Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mac.com and .tv #27

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add mac.com and .tv #27

wants to merge 2 commits into from

Conversation

benrugg
Copy link

@benrugg benrugg commented Sep 9, 2023

Description of change

Add mac.com popular domains and .tv to popular tlds, to fix false positives for both.

Fixes #25
Fixes #26

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

Notes

I am submitting both fixes at once, but I could separate them, if you'd like. I was planning on adding tests, but I realized that there weren't any tests for false positives, so I didn't add a section for that. Again, I could if you want that. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for .tv TLD False positive for mac.com
1 participant