Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive for mac.com #25

Open
benrugg opened this issue Sep 9, 2023 · 1 comment · May be fixed by #27
Open

False positive for mac.com #25

benrugg opened this issue Sep 9, 2023 · 1 comment · May be fixed by #27
Labels
bug Something isn't working

Comments

@benrugg
Copy link

benrugg commented Sep 9, 2023

False positive: anything@mac.com suggests anything@mail.com

  1. How popular is the TLDs or Domain: mac.com email addresses were issued to millions of people. Apple has moved away from them, but they still work.
  2. Why most of the companies using this package will get benefit of it: False positives for a large number of email addresses cause additional customer support costs.

Current Behavior

const suggestion = emailSpellChecker.run({ email: 'whatever@mac.com' })
suggestion.full == 'whatever@mail.com'

Expected Behavior

const suggestion = emailSpellChecker.run({ email: 'whatever@mac.com' })
suggestion == null

Steps to Reproduce the Problem

  1. See above
@benrugg benrugg added the bug Something isn't working label Sep 9, 2023
@benrugg
Copy link
Author

benrugg commented Sep 9, 2023

Thank you for this package, btw. It's really helpful! I'll try to submit a pr for this when I have a second.

@benrugg benrugg linked a pull request Sep 9, 2023 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant