helpers: ynh_remove_systemd_config: Also remove the systemd service from YunoHost. #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom YunoHost. Every app or almost will do that, because it doesn't make sense to remove the systemd config but not the associated yunohost configuration. This will clean up a bit the remove scripts.
1 task
|
We may need for an autopatcher when we merge this PR |
|
Not really, the "if" test kinda protects from "double calls" to yunohost service remove. Although agreed, the autopatcher would accelerate the cleanup :D |
|
(Let's not forget about app version dependencies to yunohost) |
Salamandar
added a commit
to YunoHost/example_ynh
that referenced
this pull request
Mar 11, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every app or almost will do that, because it doesn't make sense to remove the systemd config but not the associated yunohost configuration.
This will clean up a bit the remove scripts.