Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/iss 304 other names UI #323

Merged
merged 13 commits into from
Dec 4, 2020

Conversation

sibyl229
Copy link
Contributor

@sibyl229 sibyl229 commented Oct 28, 2020

UI changes related to other names of Genes #304

  • add other names when creating a gene
  • add other names to existing gene
  • delete other names of existing gene
  • autocomplete suggestion to include other-names if available
  • recent activities and gene history to handle multi-value other-names
  • other-names for split gene product

The PR assumes request body to have the format of:

{
  data: {
    other-names: [ name1 , name2 ... ]
  },
  prov: {
    ...
  }
}

@sibyl229 sibyl229 changed the title Feature/iss 304 other names UI (DO NOT MERGE YET) Feature/iss 304 other names UI Oct 28, 2020
@sibyl229 sibyl229 changed the title (DO NOT MERGE YET) Feature/iss 304 other names UI Feature/iss 304 other names UI Nov 12, 2020
@mluypaert mluypaert merged commit 7bb1b65 into feature/iss-304-other-names Dec 4, 2020
Copy link
Member

@mluypaert mluypaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted a change you made to the proxy, to ensure lvh.me will be used during local development (local UI can be used during local API code development).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants