Data Liberation: Add interior pages #375

StevenDufresne · 2023-12-20T06:19:20Z

This PR adds an interface for the guide location in the https://github.com/WordPress/data-liberation repository.

Screenshots

Header	Header
Home
Archive
Single

How to test the changes in this Pull Request:

run yarn wp-env run cli wp cron event run --due-now
- See this PR for background: Data Liberation: Add a data liberation handbook setup #374
Create a page data-liberation
- Associate the page-data-liberation template
Create a child page of data-liberation with the slug and

renintw

Looks good to me, mostly works as described. 👍
Left some comments.
And we can consider aligning the post title with the top of the TOC.

renintw · 2024-01-23T15:13:23Z

source/wp-content/themes/wporg-main-2022/templates/single-and-handbook.html

+
+<!-- wp:pattern {"slug":"wporg-main-2022/nav-data-liberation-single"} /-->
+
+


extra line.

renintw · 2024-01-23T15:31:13Z

source/wp-content/themes/wporg-main-2022/functions.php

+			),
+			array(
+				'url' => false,
+				'title' => get_the_title(),


This would somehow get me the title plus an edit button, is this also the case on your side?

I also see this, looks like it comes from filter_the_title_edit_link in the wporg-markdown plugin.

Is everyone okay with removing that function from the wporg-markdown plugin?

Context: #375 (comment)

If it's not going to be used anywhere, I also think we can remove it.

source/wp-content/themes/wporg-main-2022/patterns/data-liberation.php

ryelle · 2024-01-23T20:43:06Z

source/wp-content/themes/wporg-main-2022/patterns/data-liberation.php

@@ -30,56 +30,56 @@

 <!-- wp:group {"style":{"spacing":{"blockGap":"var:preset|spacing|10"}},"className":"is-style-cards-grid","layout":{"type":"grid","minimumColumnWidth":"32%"}} -->
 <div class="wp-block-group is-style-cards-grid"><!-- wp:wporg/link-wrapper -->
-<a class="wp-block-wporg-link-wrapper" href="https://github.com/WordPress/move-to-wp/blob/trunk/guides/squarespace-to-wordpress.md"><!-- wp:heading {"level":3,"style":{"spacing":{"margin":{"top":"0","bottom":"0"}},"typography":{"fontStyle":"normal","fontWeight":"700"}},"fontSize":"small","fontFamily":"inter"} -->
+<a class="wp-block-wporg-link-wrapper" href="<?php echo esc_url( site_url( 'data-liberation/and/squarespace' ) ); ?>"><!-- wp:heading {"level":3,"style":{"spacing":{"margin":{"top":"0","bottom":"0"}},"typography":{"fontStyle":"normal","fontWeight":"700"}},"fontSize":"small","fontFamily":"inter"} -->


This page is synced from the production site, so the PHP here would be overwritten when the script is run. Should it be removed from the syncing?

The hardcoded URL is a temporary solution.

An ideal solution is to implement tags/categories to control that list.

There are 2 reasons why I resorted to hardcoded items:

We don't have categories set up

The <LinkWrapper> component that was introduced in 685b3c8, doesn't play nicely with the <PostTemplate> component.

So no, they should not be removed.

I don't mean to remove the items themselves, but that the PHP here will be overwritten when yarn build:patterns is run again. So it should either be changed to href="/data-liberation/and/squarespace/" in the page content & re-synced, or this page removed from page-manifest.json and disconnect it from the syncing process.

source/wp-content/themes/wporg-main-2022/templates/single-and-handbook.html

ryelle · 2024-01-23T21:08:46Z

source/wp-content/themes/wporg-main-2022/templates/archive-and-handbook.html

+
+<!-- wp:group {"tagName":"main","style":{"spacing":{"blockGap":"0px"}},"className":"entry-content","layout":{"inherit":true,"type":"constrained"}} -->
+<main class="wp-block-group entry-content">
+	<!-- wp:pattern {"slug":"wporg-main-2022/data-liberation-guides"} /-->


Are there plans to support translating the data lib pages? If not, we probably don't need to use the pattern process here, since these pages wouldn't be rolled out to rosetta sites. (IIRC we don't have a process for translating handbooks yet, which is why i assume no)

Not a strong suggestion, but it would be one less abstraction, to put the pattern content (query loop, etc) here.

I default to yes. We should support it but understand that rosetta experiences vary right now and these pages may never be viewed in other locales... but still feel it should be localized.

okay, if we assume that it will be available eventually then 👍🏻 — my aim was to not make more work for the translators.

That's a good thought and something I haven't considered when developing. Thanks.

ryelle · 2024-01-23T21:13:41Z

source/wp-content/themes/wporg-main-2022/functions.php

+add_filter( 'wporg_handbook_toc_should_add_toc', '__return_false' );
+
+// Remove the edit link from handbook titles.
+add_filter( 'wporg_markdown_should_filter_title', '__return_false' );


I wonder why this filter seems to not exist anymore… I would have thought this would prevent the issue @renintw and I are seeing here. I can't find the filter in the wporg-markdown plugin.

Ah, dang. That was a filter I implemented in my local environment in the markdown plugin. Essentially returning early here.

I discussed this with @dd32 and since we don't use the title anywhere anymore, we agreed we could remove the function altogether and I forgot to update.

adamwoodnz · 2024-01-24T02:07:40Z

aligning the post title with the top of the TOC

Can be achieved by setting the top margin of the sidebar container via theme.json, see https://github.com/WordPress/wporg-developer/blob/trunk/source/wp-content/themes/wporg-developer-2023/theme.json#L162

StevenDufresne changed the title ~~Add the guide list pages.~~ Data Liberation: Add interior pages Dec 20, 2023

StevenDufresne force-pushed the add/data-liberation-child-pages branch from 46538c9 to 0e731ca Compare December 21, 2023 04:53

StevenDufresne mentioned this pull request Jan 15, 2024

Add handbook meta link block WordPress/wporg-mu-plugins#558

Merged

StevenDufresne force-pushed the add/data-liberation-child-pages branch from e4969f3 to c94e868 Compare January 15, 2024 05:21

StevenDufresne added 23 commits January 22, 2024 13:49

Add the guide list pages.

6b42dd5

Update all guides link.

d19edac

Add the single page view.

d58f6b1

Update the templates.

69d1544

Fix the breadcrumbs.

0cecaa7

Fix the breadcrumbs.

38fce81

Add the border top.

33152fa

Remove the edit link.

069f0c0

Remove the links in titles.

7d3f419

Fix the homepage.

d487096

Fix the miage width

e64dd41

Add a callout on the guides page.

bce74bf

Add merged changes.

705f7b2

Fix more merge conflicts.

bd190bc

Another fix.

95d5d8a

another.

13b9cb9

Another.

8653ef6

Add space.

92b2453

Update one more.

635e45d

Remove the search and count for now.

835dd86

Clean up template.

9dfecca

Clean up

c33ccbf

Run formatter.

6238975

StevenDufresne force-pushed the add/data-liberation-child-pages branch from 3911644 to 6238975 Compare January 22, 2024 04:50

StevenDufresne added 2 commits January 22, 2024 14:04

Update frontpage links.

cc9fb3c

Simplify the breadcrumbs.

731242d

StevenDufresne added 3 commits January 22, 2024 15:23

Remove the post details.

ff2f7c8

Add the padding to the container.

6353c07

Fix guides view.

ded91a8

StevenDufresne marked this pull request as ready for review January 22, 2024 07:03

StevenDufresne added 5 commits January 22, 2024 16:05

Clean up the template.

462548b

Clean up the template.

fd0cc8f

Clean up the template.

8a16b35

Add newlines.

431eeaf

Remove extra line.

96fa7f1

StevenDufresne requested review from adamwoodnz, ryelle, renintw and a team January 22, 2024 07:07

StevenDufresne added 2 commits January 23, 2024 11:24

Fix linter.

064d05e

Update site title.

54bdf05

StevenDufresne mentioned this pull request Jan 23, 2024

SEO: Change separator to pipe. #384

Open

renintw reviewed Jan 23, 2024

View reviewed changes

ryelle reviewed Jan 23, 2024

View reviewed changes

StevenDufresne added 4 commits January 24, 2024 14:40

Fix the title, article offset.

5e21c8c

Add last slach to avoid redirect.

7716d17

Add footer to single page.

b5efb17

Update heading padding to match ToC.

3d237f6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Data Liberation: Add interior pages #375

Data Liberation: Add interior pages #375

StevenDufresne commented Dec 20, 2023 •

edited

renintw left a comment

renintw Jan 23, 2024

renintw Jan 23, 2024

ryelle Jan 23, 2024

StevenDufresne Jan 24, 2024

renintw Jan 24, 2024 •

edited

ryelle Jan 23, 2024

StevenDufresne Jan 24, 2024

ryelle Jan 24, 2024

ryelle Jan 23, 2024

StevenDufresne Jan 24, 2024

ryelle Jan 24, 2024

StevenDufresne Jan 26, 2024

ryelle Jan 23, 2024

StevenDufresne Jan 24, 2024

adamwoodnz commented Jan 24, 2024 •

edited


		<!-- wp:pattern {"slug":"wporg-main-2022/nav-data-liberation-single"} /-->

Data Liberation: Add interior pages #375

Are you sure you want to change the base?

Data Liberation: Add interior pages #375

Conversation

StevenDufresne commented Dec 20, 2023 • edited

Screenshots

How to test the changes in this Pull Request:

renintw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

renintw Jan 24, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adamwoodnz commented Jan 24, 2024 • edited

StevenDufresne commented Dec 20, 2023 •

edited

renintw Jan 24, 2024 •

edited

adamwoodnz commented Jan 24, 2024 •

edited