Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KSES: Replace attribute parsing with HTML API. #6572

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

dmsnell
Copy link
Contributor

@dmsnell dmsnell commented May 17, 2024

In this patch several kses functions have been rewritten to rely on the spec-compliant parsing made available in the HTML API. These functions convert HTML input into an array of parsed attribute values. By relying on the HTML API it's possible to recognize the HTML in the same way that a browser would, removing a layer of custom interpretation, full of discrepancies and bugs.

In this patch several kses functions have been rewritten to rely on the
spec-compliant parsing made available in the HTML API. These functions
convert HTML input into an array of parsed attribute values. By relying
on the HTML API it's possible to recognize the HTML in the same way that
a browser would, removing a layer of custom interpretation, full of
discrepancies and bugs.
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@dmsnell dmsnell force-pushed the kses/hair-html-spec branch 2 times, most recently from d47b8b2 to 5079cbc Compare May 17, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant