Fix Slack message formatting for ES health alert #4345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small issue I noticed while we've been receiving ES health Slack alerts:
Since Slack forming isn't actually markdown, the double asterisk
**
was showing up as unformatted when the message should have had bold text. This PR corrects the instances of**
to use a single*
instead which will bold the message in Slack.Testing Instructions
Tests should pass.
You can also observe this locally by running the following (as a maintainer):
just c i
(to start the catalog & ingestion server resources)j run webserver variables set SLACK_MESSAGE_OVERRIDE true
(to enable sending the message to Slack)staging_elasticsearch_cluster_healthcheck
DAGChecklist
Update index.md
).main
) or a parent feature branch.just catalog/generate-docs
for catalogPRs) or the media properties generator (
just catalog/generate-docs media-props
for the catalog or
just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin