Warn on license_url computation in the API

[krysal]

Fixes

Related to #703 by @obulat

Description

In the interest of closing this PR, I changed the approach only to warn when the license is computed, as suggested by @obulat. The #703 issue will addressed when we confirm #4318 is not an issue anymore.

---

Old description

My understanding is that the computation from openverse_attribution.license.License can be removed but we still need the property.

This PR should not be merged until the updated add_license_url run is completed and it's confirmed the image table in the Catalog does not have more NULL values for this field.

If you are wondering about audio I confirmed all items have this field set to something else than NULL.

openledger> SELECT COUNT(identifier) FROM audio WHERE meta_data->>'license_url' IS NULL;
+-------+
| count |
|-------|
| 0     |
+-------+
SELECT 1
Time: 17.712s (17 seconds), executed in: 17.695s (17 seconds)

Testing Instructions

Run the API and remove the license_url of an image. Then, visit its media page and check the logs.

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[sarayourfriend]

@krysal what is the status of this PR and this particular blocker? Is the PR still blocked? Should it be labelled as such?

This PR should not be merged until the updated add_license_url run is completed and it's confirmed the image table in the Catalog does not have more NULL values for this field.

[obulat]

@krysal, what if instead of removing the computation completely we leave it in but add a warning log. Then, if there are no warnings in a longish period of time (a month?), we can remove the computation?
This would not be blocked by the DAG, and could be merged now.

[krysal]

@sarayourfriend It's blocked pending completion of #3885, which I thought would be a relatively quick task, but some problems arose.

@krysal, what if instead of removing the computation completely we leave it in but add a warning log. Then, if there are no warnings in a longish period of time (a month?), we can remove the computation?
This would not be blocked by the DAG, and could be merged now.

That is a good idea! :) I'll adapt the PR for that 👍

[AetherUnbound]

@krysal I'm going to add the blocked label for this PR while work on #3885 is being done

[stacimc]

This looks fine to me, I was able to see the log after removing the meta_data from a record locally. It's been a minute since I've looked at this -- can you remind me what cases we're trying to catch here? I thought the catalog should be enforcing setting the licenses now, and that incorrect cases had already been backfilled, but maybe I'm misremembering.

If there isn't one already, can we make an issue for checking the production logs so that it does not get forgotten?

[dhruvkb]

LGTM! Added a suggestion to make logging more structured but it's not a blocker in my view.

[krysal]

This looks fine to me, I was able to see the log after removing the meta_data from a record locally. It's been a minute since I've looked at this -- can you remind me what cases we're trying to catch here? I thought the catalog should be enforcing setting the licenses now, and that incorrect cases had already been backfilled, but maybe I'm misremembering.

If there isn't one already, can we make an issue for checking the production logs so that it does not get forgotten?

@stacimc I'm also hoping we don't see more incorrect cases but I created #4318 to wait and confirm that. There is also more explanation of the reasoning.