Improve link conrol preview when show button text label is enabled. #61726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +13 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Seems fine as a interim fix. It would be good to see how these patterns can scale to other contexts, it seems likely that in some contexts, stacking won't work, and scrolling or some overflow handling may be required. |
t-hamano
approved these changes
May 20, 2024
There was a problem hiding this comment.
This PR is working as expected to me and I think it's okay to ship it as is.
The video below shows how buttons wrap properly even in a narrow viewport without overflowing.
53042c61a1d17d5b40450f65068e4afb.mp4
A more serious problem, not related to this PR, is that the text in the block toolbar is awkwardly wrapped 😅
|
Nice. Question. Why not remove the justification?
|
Just wanted to keep the right alignment to not introduce unrelated changes. Will adjust it.
Horizontal scrolling should be avoided as it's unexpected and difficult for keyboard users. Also, regardless whether it's vertical or horizontal scrolling, the editor still doesn't have a 'scrollable div' component that is fully accessible. In #47426 I did some work to make the modal dialog scrollable content fully accessible but I couldn't find the time amd momentum to port that to a more abstracted component.
That is very likely to happen wherever fixed heights are in use. Elements with fixed sizes and/or fixed or sticky positioning are known to trigger that kind of problem. Ideally, fixed sizes should be avoided to allow content to behave as it is expected to on the web: to reflow and adapt to a changing viewport. |
afercia
force-pushed
the
try/link-control-preview-show-button-text-labels
branch
from
f0a1916
to
5ac4cba
Compare
|
Latest commit removes the right alignment when the preference is enabled. Screenshots in English, Spanish, and Japanese:
|
|
Flaky tests detected in 5ac4cba. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9210022752
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #61158
What?
When the 'Show button text labels' preference is enabled, the LInkControl preview has very limited horizontal space to show its content, especially with some languages. See screenshots at #61158 (comment)
Both the link preview and the buttons with visible text need more horizontal space.
When 'Show button text labels' is enabled, there is no need to show the preview and the buttons on the same line. IN a way, 'Show button text labels' already changes the UI and it is reasonable to accomodate a different layout for the buttons with visible text. Laying out the buttons on a new line appears to be the simplest and more effective solution.
Pinging a few people who worked on this UI or are familiar with non-westeren languages:
@richtabor @MaggieCabrera @scruffian @getdave @t-hamano
Why?
How?
Makes the buttons go in a new line, only when the
Show button text labelspreference is enabled. There should be no visual changes for the default layout with icon buttons.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
After
Default is unchanged:
'Show button text labels' enabled, English:
'Show button text labels' enabled, Spanish:
'Show button text labels' enabled, Japanese: