Update modal width to 65vw #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhusudhand
requested review from
pbking,
t-hamano and
vcanales
and removed request for
pbking and
t-hamano
t-hamano
reviewed
May 15, 2024
There was a problem hiding this comment.
The Modal component can now define its width via the size prop. What do you think about using this prop instead of defining width in CSS? However, when using this props, the modal's height will not be full.
<Modal
size="large"
>
</Modal>
madhusudhand
force-pushed
the
update-modal-ui
branch
from
b587221
to
1e81d13
Compare
|
What if additionally we shifted the 'screenshot' and 'subfolder' (two items that are pretty narrow) to a second, smaller column on the right? 
|
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Merged
I think this is an interesting idea and may be considered in another PR. |
pbking
approved these changes
May 28, 2024
|
I fixed the conflicts to merge this and include it in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings the following UI changes.
65vw(similar to font library in core)In addition to these UI changes, it also introduces a style-sheet for adding class definitions.