Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendered text extraction should exclude Live Text #28759

Merged
merged 1 commit into from
May 18, 2024

Conversation

whsieh
Copy link
Member

@whsieh whsieh commented May 18, 2024

098f678

Rendered text extraction should exclude Live Text
https://bugs.webkit.org/show_bug.cgi?id=274355
rdar://128213708

Reviewed by Richard Robinson.

Exclude Live Text in UA shadow roots under image elements, for the purposes of extracting rendered
text.

* LayoutTests/fast/element-targeting/target-rendered-text-excludes-live-text-expected.txt: Added.
* LayoutTests/fast/element-targeting/target-rendered-text-excludes-live-text.html: Added.
* Source/WebCore/page/text-extraction/TextExtraction.cpp:
(WebCore::TextExtraction::extractRenderedText):

Canonical link: https://commits.webkit.org/278961@main

fc9a580

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2 βœ… πŸ§ͺ wincairo-tests
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  wpe-cairo
  πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2-stress βœ… πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@whsieh whsieh requested a review from cdumez as a code owner May 18, 2024 20:24
@whsieh whsieh self-assigned this May 18, 2024
@whsieh whsieh added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label May 18, 2024
@whsieh whsieh added the merge-queue Applied to send a pull request to merge-queue label May 18, 2024
@whsieh
Copy link
Member Author

whsieh commented May 18, 2024

Thanks for the review!

https://bugs.webkit.org/show_bug.cgi?id=274355
rdar://128213708

Reviewed by Richard Robinson.

Exclude Live Text in UA shadow roots under image elements, for the purposes of extracting rendered
text.

* LayoutTests/fast/element-targeting/target-rendered-text-excludes-live-text-expected.txt: Added.
* LayoutTests/fast/element-targeting/target-rendered-text-excludes-live-text.html: Added.
* Source/WebCore/page/text-extraction/TextExtraction.cpp:
(WebCore::TextExtraction::extractRenderedText):

Canonical link: https://commits.webkit.org/278961@main
@webkit-commit-queue
Copy link
Collaborator

Committed 278961@main (098f678): https://commits.webkit.org/278961@main

Reviewed commits have been landed. Closing PR #28759 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 098f678 into WebKit:main May 18, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
4 participants