Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyHandle should have a virtual destructor #28758

Merged
merged 1 commit into from
May 18, 2024

Conversation

@rniwa rniwa self-assigned this May 18, 2024
@rniwa rniwa added the Media Bugs related to the HTML 5 Media elements. label May 18, 2024
@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 18, 2024
https://bugs.webkit.org/show_bug.cgi?id=274354

Reviewed by Chris Dumez.

Added a virtual destructor since this class has subclasses.

* Source/WebCore/platform/encryptedmedia/CDMProxy.h:
(WebCore::KeyHandle::~KeyHandle):

Canonical link: https://commits.webkit.org/278963@main
@webkit-commit-queue
Copy link
Collaborator

Committed 278963@main (20328d8): https://commits.webkit.org/278963@main

Reviewed commits have been landed. Closing PR #28758 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 20328d8 into WebKit:main May 18, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 18, 2024
@rniwa rniwa deleted the add-vdtor-on-keyhandle branch May 21, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
4 participants