Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOMException should have a virtual destructor #28756

Merged
merged 1 commit into from
May 20, 2024
Merged

DOMException should have a virtual destructor #28756

merged 1 commit into from
May 20, 2024
+2 −0

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented May 18, 2024 •
edited by webkit-early-warning-system

26c6625

DOMException should have a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=274352

Reviewed by Chris Dumez.

Added a virtual destructor since this class has subclasses.

* Source/WebCore/dom/DOMException.h:
(WebCore::DOMException::~DOMException):

Canonical link: https://commits.webkit.org/278981@main

2ac1299

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@rniwa rniwa requested a review from cdumez as a code owner May 18, 2024 18:54
@rniwa rniwa self-assigned this May 18, 2024
@rniwa rniwa added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label May 18, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 7b8d671)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez
Copy link
Contributor

cdumez commented May 18, 2024

DOMException should have a virtue destructor

Typo: virtual

@rniwa rniwa changed the title DOMException should have a virtue destructor DOMException should have a virtual destructor May 18, 2024
@rniwa rniwa force-pushed the add-vdtor-on-domexception branch from 7b8d671 to 2ac1299 Compare May 18, 2024 22:19
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 2ac1299)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 20, 2024
@rniwa
DOMException should have a virtual destructor
26c6625 
https://bugs.webkit.org/show_bug.cgi?id=274352

Reviewed by Chris Dumez.

Added a virtual destructor since this class has subclasses.

* Source/WebCore/dom/DOMException.h:
(WebCore::DOMException::~DOMException):

Canonical link: https://commits.webkit.org/278981@main
@webkit-commit-queue webkit-commit-queue merged commit 26c6625 into WebKit:main May 20, 2024
@webkit-commit-queue
Copy link
Collaborator

Committed 278981@main (26c6625): https://commits.webkit.org/278981@main

Reviewed commits have been landed. Closing PR #28756 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 20, 2024
@rniwa rniwa deleted the add-vdtor-on-domexception branch May 20, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

Assignees

@rniwa rniwa

Labels
DOM For bugs specific to XML/HTML DOM elements (including parsing).
Projects
None yet
Milestone
No milestone
4 participants
@rniwa @webkit-early-warning-system @cdumez @webkit-commit-queue