Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make loadURLIntoChildFrame use loadWithNavigationAction #28753

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make loadURLIntoChildFrame use loadWithNavigationAction #28753

wants to merge 1 commit into from

Conversation

rwlbuis
Copy link
Contributor

@rwlbuis rwlbuis commented May 18, 2024 •
edited by webkit-early-warning-system

1b8f8bf

Make loadURLIntoChildFrame use loadWithNavigationAction
https://bugs.webkit.org/show_bug.cgi?id=274348

Reviewed by NOBODY (OOPS!).

WIP.

* Source/WebCore/loader/FrameLoadRequest.h:
(WebCore::FrameLoadRequest::isInitialFrameSrcLoad const): Deleted.
(WebCore::FrameLoadRequest::setIsInitialFrameSrcLoad): Deleted.
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURLIntoChildFrame):
(WebCore::FrameLoader::loadURL):

1b8f8bf

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 watch-sim

@rwlbuis
Make loadURLIntoChildFrame use loadWithNavigationAction
1b8f8bf 
https://bugs.webkit.org/show_bug.cgi?id=274348

Reviewed by NOBODY (OOPS!).

WIP.

* Source/WebCore/loader/FrameLoadRequest.h:
(WebCore::FrameLoadRequest::isInitialFrameSrcLoad const): Deleted.
(WebCore::FrameLoadRequest::setIsInitialFrameSrcLoad): Deleted.
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURLIntoChildFrame):
(WebCore::FrameLoader::loadURL):
@rwlbuis rwlbuis requested a review from cdumez as a code owner May 18, 2024 13:51
@rwlbuis rwlbuis self-assigned this May 18, 2024
@rwlbuis rwlbuis added the Page Loading For bugs in page loading, including handling of network callbacks. label May 18, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 1b8f8bf)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 watch-sim

@rwlbuis rwlbuis removed the request for review from cdumez May 18, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rwlbuis rwlbuis

Labels
Page Loading For bugs in page loading, including handling of network callbacks.
Projects
None yet
Milestone
No milestone
2 participants
@rwlbuis @webkit-early-warning-system