Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of NSURLErrorFailingURLStringErrorKey in TestWebKitAPI.WKNavigation #28749

Merged
merged 1 commit into from
May 20, 2024
Merged

Remove usage of NSURLErrorFailingURLStringErrorKey in TestWebKitAPI.WKNavigation #28749

merged 1 commit into from
May 20, 2024

Conversation

guoye-zhang
Copy link
Contributor

@guoye-zhang guoye-zhang commented May 18, 2024 •
edited by webkit-early-warning-system

824d8ae

Remove usage of NSURLErrorFailingURLStringErrorKey in TestWebKitAPI.WKNavigation
https://bugs.webkit.org/show_bug.cgi?id=274343

Reviewed by Alex Christensen.

The new HTTP stack no longer produces NSURLErrorFailingURLStringErrorKey in the user info dictionary.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
(TEST(WKNavigation, HTTPSOnlyWithSameSiteBypass)):
(TEST(WKNavigation, HTTPSOnlyWithHTTPRedirect)):

Canonical link: https://commits.webkit.org/279011@main

881591a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 881591a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@achristensen07 achristensen07 added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label May 18, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 18, 2024
@webkit-ews-buildbot
Copy link
Collaborator

Failed ios-wk2-wpt, api-gtk checks. Please resolve failures and re-apply safe-merge-queue label.

Rejecting #28749 from merge queue.

@webkit-ews-buildbot webkit-ews-buildbot removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label May 18, 2024
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #21149.

@guoye-zhang
Copy link
Contributor Author

The test failures don't seem related

@achristensen07 achristensen07 added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels May 20, 2024
@guoye-zhang @achristensen07
Remove usage of NSURLErrorFailingURLStringErrorKey in TestWebKitAPI.W…
824d8ae 
…KNavigation

https://bugs.webkit.org/show_bug.cgi?id=274343

Reviewed by Alex Christensen.

The new HTTP stack no longer produces NSURLErrorFailingURLStringErrorKey in the user info dictionary.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
(TEST(WKNavigation, HTTPSOnlyWithSameSiteBypass)):
(TEST(WKNavigation, HTTPSOnlyWithHTTPRedirect)):

Canonical link: https://commits.webkit.org/279011@main
@webkit-commit-queue
Copy link
Collaborator

Committed 279011@main (824d8ae): https://commits.webkit.org/279011@main

Reviewed commits have been landed. Closing PR #28749 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 824d8ae into WebKit:main May 20, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 20, 2024
@guoye-zhang guoye-zhang deleted the r274343 branch May 25, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achristensen07 achristensen07 achristensen07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@guoye-zhang @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @achristensen07