Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INADDR_LOOPBACK needs to be swapped to network endian #28736

Merged
merged 1 commit into from
May 20, 2024

Conversation

@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 20, 2024
https://bugs.webkit.org/show_bug.cgi?id=274336

Reviewed by Matthew Finkel.

IPAddress::isLoopback() compares in_addr with INADDR_LOOPBACK without swapping the byte order.

* Source/WebCore/platform/network/DNS.cpp:
(WebCore::IPAddress::isLoopback const):

Canonical link: https://commits.webkit.org/279010@main
@webkit-commit-queue
Copy link
Collaborator

Committed 279010@main (76d8f25): https://commits.webkit.org/279010@main

Reviewed commits have been landed. Closing PR #28736 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 76d8f25 into WebKit:main May 20, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 20, 2024
@guoye-zhang guoye-zhang deleted the r274336 branch May 25, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants