[WebGPU] Queue::writeTexture may write outside its temporary buffer #28735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 337bad4) |
mwyrzykowski
force-pushed
the
eng/WebGPU-QueuewriteTexture-may-write-outside-its-temporary-buffer
branch
from
337bad4
to
6f8e343
Compare
|
EWS run on previous version of this PR (hash 6f8e343) |
mwyrzykowski
force-pushed
the
eng/WebGPU-QueuewriteTexture-may-write-outside-its-temporary-buffer
branch
from
6f8e343
to
78ddfc1
Compare
|
EWS run on current version of this PR (hash 78ddfc1) |
mwyrzykowski
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=274171 <radar://128064885> Reviewed by Dan Glastonbury. bytesPerImage must be a multiple of the blockHeight, but the division was occurring outside the max() operation instead of inside the right hand side. * LayoutTests/TestExpectations: * LayoutTests/fast/webgpu/fuzz-274171-expected.txt: Added. * LayoutTests/fast/webgpu/fuzz-274171.html: Added. Add regression test. * Source/WebGPU/WebGPU/Queue.mm: (WebGPU::Queue::writeTexture): Canonical link: https://commits.webkit.org/279027@main
webkit-commit-queue
force-pushed
the
eng/WebGPU-QueuewriteTexture-may-write-outside-its-temporary-buffer
branch
from
78ddfc1
to
33e3b62
Compare
|
Committed 279027@main (33e3b62): https://commits.webkit.org/279027@main Reviewed commits have been landed. Closing PR #28735 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
33e3b62
78ddfc1
🛠 ios🛠 wpe🛠 wincairo🧪 wpe-wk2🧪 wincairo-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🛠 wpe-cairo🧪 api-ios🧪 mac-wk2🛠 gtk🛠 tv🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 tv-sim🧪 mac-wk2-stress🧪 api-gtk🛠 watch🛠 watch-sim