Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

textarea's width calculations aren't fully writing mode aware #28733

Merged
merged 1 commit into from
May 22, 2024
Merged

textarea's width calculations aren't fully writing mode aware #28733

merged 1 commit into from
May 22, 2024

Conversation

lukewarlow
Copy link
Member

@lukewarlow lukewarlow commented May 17, 2024 •
edited by webkit-early-warning-system

708db46

textarea's width calculations aren't fully writing mode aware
https://bugs.webkit.org/show_bug.cgi?id=274332

Reviewed by Aditya Keerthi.

Updates the width cacluations to take into account writing mode when decided whether to add scrollbar thickness.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/textarea-scrollbar-sizing-002-expected.txt:
* Source/WebCore/rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::preferredContentLogicalWidth const):

Canonical link: https://commits.webkit.org/279150@main

0e0080c

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@lukewarlow lukewarlow self-assigned this May 17, 2024
@lukewarlow lukewarlow added the CSS Cascading Style Sheets implementation label May 17, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 3b9485f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 18, 2024
@lukewarlow lukewarlow removed the merging-blocked Applied to prevent a change from being merged label May 22, 2024
@lukewarlow lukewarlow changed the title textarea's width calculations aren't writing mode aware textarea's width calculations aren't fully writing mode aware May 22, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 0e0080c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@lukewarlow lukewarlow marked this pull request as ready for review May 22, 2024 16:12
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 22, 2024
@lukewarlow lukewarlow removed the merging-blocked Applied to prevent a change from being merged label May 22, 2024
@lukewarlow lukewarlow added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label May 22, 2024
@webkit-ews-buildbot webkit-ews-buildbot removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label May 22, 2024
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #21566.

@webkit-ews-buildbot webkit-ews-buildbot added the merge-queue Applied to send a pull request to merge-queue label May 22, 2024
@lukewarlow
textarea's width calculations aren't fully writing mode aware
708db46 
https://bugs.webkit.org/show_bug.cgi?id=274332

Reviewed by Aditya Keerthi.

Updates the width cacluations to take into account writing mode when decided whether to add scrollbar thickness.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/textarea-scrollbar-sizing-002-expected.txt:
* Source/WebCore/rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::preferredContentLogicalWidth const):

Canonical link: https://commits.webkit.org/279150@main
@webkit-commit-queue
Copy link
Collaborator

Committed 279150@main (708db46): https://commits.webkit.org/279150@main

Reviewed commits have been landed. Closing PR #28733 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 708db46 into WebKit:main May 22, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxlcoder pxlcoder pxlcoder approved these changes

Assignees

@lukewarlow lukewarlow

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
5 participants
@lukewarlow @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @pxlcoder