Pass invalidation handler to ExtensionProcess::grantCapability #28731

pvollan · 2024-05-17T21:16:13Z

`1191300`

Pass invalidation handler to ExtensionProcess::grantCapability
https://bugs.webkit.org/show_bug.cgi?id=274331
rdar://126825362

Reviewed by Chris Dumez.

In order for the invalidation handler to be called when the grant is invalidated, we need to
pass the invalidation handler to ExtensionProcess::grantCapability.

* Source/WebKit/Platform/cocoa/AssertionCapability.h:
* Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm:
(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAssertion::acquireSync):
(WebKit::Function<void):
* Source/WebKit/UIProcess/Launcher/ProcessLauncher.h:
* Source/WebKit/UIProcess/Launcher/cocoa/ExtensionProcess.h:
* Source/WebKit/UIProcess/Launcher/cocoa/ExtensionProcess.mm:
(WebKit::ExtensionProcess::grantCapability const):
* Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::LaunchGrant::LaunchGrant):
(WebKit::LaunchGrant::~LaunchGrant):
* Source/WebKit/UIProcess/ProcessAssertion.h:

Canonical link: https://commits.webkit.org/279428@main

a4e26e4

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	~~🛠 ios-sim~~	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~		✅ 🛠 wpe-cairo
	~~🧪 api-ios~~	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	~~🧪 api-gtk~~
	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-17T21:16:19Z

EWS run on previous version of this PR (hash 9a66f23)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 wincairo~~
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2	~~🧪 wincairo-tests~~
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	~~🧪 api-mac~~	✅ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt		✅ 🛠 wpe-cairo
	~~🧪 api-ios~~	✅ 🧪 mac-wk2	✅ 🛠 gtk
	~~🛠 tv~~	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 gtk-wk2
	~~🛠 tv-sim~~	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-05-17T22:27:49Z

EWS run on previous version of this PR (hash 2b99bd1)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt		✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

cdumez · 2024-05-21T16:58:16Z

Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm

@@ -388,14 +388,6 @@ static ASCIILiteral runningBoardDomainForAssertionType(ProcessAssertionType asse
    if (process.extensionProcess()) {
        ASCIILiteral runningBoardAssertionName = runningBoardNameForAssertionType(m_assertionType);
        ASCIILiteral runningBoardDomain = runningBoardDomainForAssertionType(m_assertionType);
-        auto didInvalidateBlock = [weakThis = ThreadSafeWeakPtr { *this }, runningBoardAssertionName] () {


Why this change?

Presumably so the code can be shared with the call on L477

Yes, that is correct.

Thanks for reviewing, all!

bnham · 2024-05-21T17:33:00Z

Source/WebKit/UIProcess/Launcher/cocoa/ExtensionProcess.mm

@@ -84,7 +88,7 @@
    return grant;
 }

-PlatformGrant ExtensionProcess::grantCapability(const PlatformCapability& capability) const
+PlatformGrant ExtensionProcess::grantCapability(const PlatformCapability& capability, Function<void()>&& invalidationHandler) const


Could this take an AssertionCapability instead of a PlatformCapability as an argument and just use the m_didInvalidateBlock from AssertionCapability? It seems a bit weird to be passing the invalidation block in two different places...

That's a good point! I will make that change.

I started on this change, but it became more involving than expected, because this method is also used to grant Media capabilities. Would you be OK with the current approach, Ben?

webkit-early-warning-system · 2024-05-24T17:22:32Z

EWS run on previous version of this PR (hash 7f49181)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	❌ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2	~~🧪 wincairo-tests~~
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	⏳ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt		✅ 🛠 wpe-cairo
	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	⏳ 🧪 gtk-wk2
	~~🛠 tv-sim~~	✅ 🧪 mac-wk2-stress	⏳ 🧪 api-gtk
	~~🛠 watch~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-24T18:25:53Z

EWS run on previous version of this PR (hash 1b9e666)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	❌ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2	⏳ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	~~🧪 api-mac~~	⏳ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt		✅ 🛠 wpe-cairo
	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 gtk-wk2
	~~🛠 tv-sim~~	✅ 🧪 mac-wk2-stress	⏳ 🧪 api-gtk
	~~🛠 watch~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-24T19:05:13Z

EWS run on previous version of this PR (hash 4e1886e)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	~~🛠 wincairo~~
	~~🛠 ios-sim~~	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 wincairo-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🧪 api-mac	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~		~~🛠 wpe-cairo~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🛠 gtk~~
	~~🛠 tv~~	⏳ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	~~🛠 tv-sim~~	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-05-24T19:12:24Z

EWS run on previous version of this PR (hash c1f9e37)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	❌ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2	⏳ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	⏳ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt		✅ 🛠 wpe-cairo
	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 gtk-wk2
	~~🛠 tv-sim~~	✅ 🧪 mac-wk2-stress	⏳ 🧪 api-gtk
	~~🛠 watch~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-24T20:30:46Z

EWS run on previous version of this PR (hash 7c77bf4)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	❌ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt		✅ 🛠 wpe-cairo
	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	⏳ 🧪 api-gtk
	~~🛠 watch~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-25T15:55:06Z

EWS run on previous version of this PR (hash ce15a65)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt		✅ 🛠 wpe-cairo
	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🛠 gtk
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 tv-sim	~~🧪 mac-wk2-stress~~	⏳ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-25T16:08:09Z

EWS run on previous version of this PR (hash 00abc02)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt		✅ 🛠 wpe-cairo
	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-28T03:06:32Z

EWS run on previous version of this PR (hash 9a60324)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	❌ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt		✅ 🛠 wpe-cairo
	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	~~🛠 tv-sim~~	✅ 🧪 mac-wk2-stress	~~🧪 api-gtk~~
	~~🛠 watch~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-28T04:15:33Z

EWS run on previous version of this PR (hash ad2dbb8)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt		✅ 🛠 wpe-cairo
	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

pvollan · 2024-05-28T19:01:38Z

Looking closer, I think the test failures on iOS are unrelated to this patch.

cdumez · 2024-05-28T20:28:03Z

Pass invalidation handler to ExtensionProcess::grantCapability
https://bugs.webkit.org/show_bug.cgi?id=274331
rdar://126825362

This radar is already in Integrate so I doubt this is the right link.

pvollan · 2024-05-28T20:39:42Z

Pass invalidation handler to ExtensionProcess::grantCapability
https://bugs.webkit.org/show_bug.cgi?id=274331
rdar://126825362

This radar is already in Integrate so I doubt this is the right link.

Ah, good catch, the radar state was not correct.

Thanks for approving, Chris!

webkit-early-warning-system · 2024-05-29T02:55:10Z

EWS run on current version of this PR (hash a4e26e4)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	~~🛠 ios-sim~~	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~		✅ 🛠 wpe-cairo
	~~🧪 api-ios~~	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	~~🧪 api-gtk~~
	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=274331 rdar://126825362 Reviewed by Chris Dumez. In order for the invalidation handler to be called when the grant is invalidated, we need to pass the invalidation handler to ExtensionProcess::grantCapability. * Source/WebKit/Platform/cocoa/AssertionCapability.h: * Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm: (WebKit::ProcessAssertion::ProcessAssertion): (WebKit::ProcessAssertion::acquireSync): (WebKit::Function<void): * Source/WebKit/UIProcess/Launcher/ProcessLauncher.h: * Source/WebKit/UIProcess/Launcher/cocoa/ExtensionProcess.h: * Source/WebKit/UIProcess/Launcher/cocoa/ExtensionProcess.mm: (WebKit::ExtensionProcess::grantCapability const): * Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm: (WebKit::LaunchGrant::LaunchGrant): (WebKit::LaunchGrant::~LaunchGrant): * Source/WebKit/UIProcess/ProcessAssertion.h: Canonical link: https://commits.webkit.org/279428@main

webkit-commit-queue · 2024-05-29T05:30:23Z

Committed 279428@main (1191300): https://commits.webkit.org/279428@main

Reviewed commits have been landed. Closing PR #28731 and removing active labels.

pvollan requested a review from cdumez as a code owner May 17, 2024 21:16

pvollan self-assigned this May 17, 2024

pvollan added the WebKit Process Model Bugs related to WebKit's multi-process architecture label May 17, 2024

pvollan force-pushed the eng/Pass-invalidation-handler-to-ExtensionProcessgrantCapability branch from 9a66f23 to 2b99bd1 Compare May 17, 2024 22:27

pvollan requested a review from xeenon May 17, 2024 23:25

cdumez reviewed May 21, 2024

View reviewed changes

bnham reviewed May 21, 2024

View reviewed changes

pvollan force-pushed the eng/Pass-invalidation-handler-to-ExtensionProcessgrantCapability branch from 2b99bd1 to 7f49181 Compare May 24, 2024 17:22

pvollan requested review from cdumez and bnham May 24, 2024 17:23

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 24, 2024

pvollan removed the merging-blocked Applied to prevent a change from being merged label May 24, 2024

pvollan force-pushed the eng/Pass-invalidation-handler-to-ExtensionProcessgrantCapability branch from 7f49181 to 1b9e666 Compare May 24, 2024 18:25

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 24, 2024

pvollan removed the merging-blocked Applied to prevent a change from being merged label May 24, 2024

pvollan force-pushed the eng/Pass-invalidation-handler-to-ExtensionProcessgrantCapability branch from 1b9e666 to 4e1886e Compare May 24, 2024 19:05

pvollan force-pushed the eng/Pass-invalidation-handler-to-ExtensionProcessgrantCapability branch from 4e1886e to c1f9e37 Compare May 24, 2024 19:12

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 24, 2024

pvollan removed the merging-blocked Applied to prevent a change from being merged label May 24, 2024

pvollan force-pushed the eng/Pass-invalidation-handler-to-ExtensionProcessgrantCapability branch from c1f9e37 to 7c77bf4 Compare May 24, 2024 20:30

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 24, 2024

pvollan removed the merging-blocked Applied to prevent a change from being merged label May 25, 2024

pvollan force-pushed the eng/Pass-invalidation-handler-to-ExtensionProcessgrantCapability branch from 7c77bf4 to 5bfe028 Compare May 25, 2024 00:08

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 25, 2024

pvollan removed the merging-blocked Applied to prevent a change from being merged label May 25, 2024

pvollan force-pushed the eng/Pass-invalidation-handler-to-ExtensionProcessgrantCapability branch from 047e663 to ce15a65 Compare May 25, 2024 15:55

pvollan force-pushed the eng/Pass-invalidation-handler-to-ExtensionProcessgrantCapability branch from ce15a65 to 00abc02 Compare May 25, 2024 16:08

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 25, 2024

pvollan removed the merging-blocked Applied to prevent a change from being merged label May 26, 2024

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 27, 2024

pvollan removed the merging-blocked Applied to prevent a change from being merged label May 28, 2024

pvollan force-pushed the eng/Pass-invalidation-handler-to-ExtensionProcessgrantCapability branch from 00abc02 to 9a60324 Compare May 28, 2024 03:06

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 28, 2024

pvollan removed the merging-blocked Applied to prevent a change from being merged label May 28, 2024

pvollan force-pushed the eng/Pass-invalidation-handler-to-ExtensionProcessgrantCapability branch from 9a60324 to ad2dbb8 Compare May 28, 2024 04:15

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 28, 2024

cdumez approved these changes May 28, 2024

View reviewed changes

pvollan removed the merging-blocked Applied to prevent a change from being merged label May 29, 2024

pvollan force-pushed the eng/Pass-invalidation-handler-to-ExtensionProcessgrantCapability branch from ad2dbb8 to a4e26e4 Compare May 29, 2024 02:55

pvollan added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 29, 2024

webkit-commit-queue force-pushed the eng/Pass-invalidation-handler-to-ExtensionProcessgrantCapability branch from a4e26e4 to 1191300 Compare May 29, 2024 05:30

webkit-commit-queue merged commit 1191300 into WebKit:main May 29, 2024

webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pass invalidation handler to ExtensionProcess::grantCapability #28731

Pass invalidation handler to ExtensionProcess::grantCapability #28731

pvollan commented May 17, 2024 •

edited by webkit-early-warning-system

webkit-early-warning-system commented May 17, 2024 •

edited

webkit-early-warning-system commented May 17, 2024 •

edited

cdumez May 21, 2024

bnham May 21, 2024

pvollan May 24, 2024

bnham May 21, 2024

pvollan May 24, 2024

pvollan May 28, 2024

webkit-early-warning-system commented May 24, 2024 •

edited

webkit-early-warning-system commented May 24, 2024 •

edited

webkit-early-warning-system commented May 24, 2024 •

edited

webkit-early-warning-system commented May 24, 2024 •

edited

webkit-early-warning-system commented May 24, 2024 •

edited

webkit-early-warning-system commented May 25, 2024 •

edited

webkit-early-warning-system commented May 25, 2024 •

edited

webkit-early-warning-system commented May 28, 2024 •

edited

webkit-early-warning-system commented May 28, 2024 •

edited

pvollan commented May 28, 2024

cdumez commented May 28, 2024

pvollan commented May 28, 2024

webkit-early-warning-system commented May 29, 2024 •

edited

webkit-commit-queue commented May 29, 2024

Pass invalidation handler to ExtensionProcess::grantCapability #28731

Pass invalidation handler to ExtensionProcess::grantCapability #28731

Conversation

pvollan commented May 17, 2024 • edited by webkit-early-warning-system

1191300

webkit-early-warning-system commented May 17, 2024 • edited

webkit-early-warning-system commented May 17, 2024 • edited

cdumez May 21, 2024

Choose a reason for hiding this comment

bnham May 21, 2024

Choose a reason for hiding this comment

pvollan May 24, 2024

Choose a reason for hiding this comment

bnham May 21, 2024

Choose a reason for hiding this comment

pvollan May 24, 2024

Choose a reason for hiding this comment

pvollan May 28, 2024

Choose a reason for hiding this comment

webkit-early-warning-system commented May 24, 2024 • edited

webkit-early-warning-system commented May 24, 2024 • edited

webkit-early-warning-system commented May 24, 2024 • edited

webkit-early-warning-system commented May 24, 2024 • edited

webkit-early-warning-system commented May 24, 2024 • edited

webkit-early-warning-system commented May 25, 2024 • edited

webkit-early-warning-system commented May 25, 2024 • edited

webkit-early-warning-system commented May 28, 2024 • edited

webkit-early-warning-system commented May 28, 2024 • edited

pvollan commented May 28, 2024

cdumez commented May 28, 2024

pvollan commented May 28, 2024

webkit-early-warning-system commented May 29, 2024 • edited

webkit-commit-queue commented May 29, 2024

pvollan commented May 17, 2024 •

edited by webkit-early-warning-system

`1191300`

webkit-early-warning-system commented May 17, 2024 •

edited

webkit-early-warning-system commented May 17, 2024 •

edited

webkit-early-warning-system commented May 24, 2024 •

edited

webkit-early-warning-system commented May 24, 2024 •

edited

webkit-early-warning-system commented May 24, 2024 •

edited

webkit-early-warning-system commented May 24, 2024 •

edited

webkit-early-warning-system commented May 24, 2024 •

edited

webkit-early-warning-system commented May 25, 2024 •

edited

webkit-early-warning-system commented May 25, 2024 •

edited

webkit-early-warning-system commented May 28, 2024 •

edited

webkit-early-warning-system commented May 28, 2024 •

edited

webkit-early-warning-system commented May 29, 2024 •

edited