[WebGPU] A12x devices and earlier allowed for creation of more samplers than supported by the HW #28730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash fd1c424)
|
mwyrzykowski
force-pushed
the
eng/WebGPU-A12x-devices-and-earlier-allowed-for-creation-of-more-samplers-than-supported-by-the-HW
branch
from
fd1c424
to
4b46bc3
Compare
|
EWS run on previous version of this PR (hash 4b46bc3) |
webkit-ews-buildbot
added
the
merging-blocked
mwyrzykowski
removed
the
merging-blocked
webkit-ews-buildbot
added
the
merging-blocked
mwyrzykowski
removed
the
merging-blocked
mwyrzykowski
force-pushed
the
eng/WebGPU-A12x-devices-and-earlier-allowed-for-creation-of-more-samplers-than-supported-by-the-HW
branch
from
4b46bc3
to
50e84c7
Compare
|
EWS run on current version of this PR (hash 50e84c7) |
…rs than supported by the HW https://bugs.webkit.org/show_bug.cgi?id=274334 <radar://128065020> Reviewed by Dan Glastonbury. Apple4 and Apple5 devices have Tier 1 AB support, not tier 2, but their limits were set according to tier 1 limits. These are mostly older phones and iPads (iPhone XS, 2018 iPad Pro), so we can instead use the default WebGPU limits which many websites may use in any case. Apple3 is not supported by WebGPU core, rather only WebGPU compat mode, which we don't have any validation for right now. * LayoutTests/fast/webgpu/fuzz-274334-expected.txt: Added. * LayoutTests/fast/webgpu/fuzz-274334.html: Added. * LayoutTests/TestExpectations Add regression test. * Source/WebGPU/WebGPU/HardwareCapabilities.mm: (WebGPU::rawHardwareCapabilities): (WebGPU::apple3): Deleted. (WebGPU::apple4): Deleted. (WebGPU::apple5): Deleted. Use default limits for Apple3/4/5 Canonical link: https://commits.webkit.org/279016@main
|
Committed 279016@main (a19c25f): https://commits.webkit.org/279016@main Reviewed commits have been landed. Closing PR #28730 and removing active labels. |
webkit-commit-queue
force-pushed
the
eng/WebGPU-A12x-devices-and-earlier-allowed-for-creation-of-more-samplers-than-supported-by-the-HW
branch
from
50e84c7
to
a19c25f
Compare
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a19c25f
50e84c7
🛠 wincairo🧪 wpe-wk2🧪 wincairo-tests🧪 api-mac🧪 ios-wk2-wpt🧪 api-ios🛠 tv🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 tv-sim🧪 api-gtk🛠 watch