[GLIB] Generate serialization for DMABuf classes #28725

psaavedra · 2024-05-17T19:40:43Z

`4b24153`

[GLIB] Generate serialization for DMABuf classes
https://bugs.webkit.org/show_bug.cgi?id=274328

Reviewed by NOBODY (OOPS!).

Explanation of why this fixes the bug (OOPS!).
* Added new serialization description files for `DMABufColorSpace`,
  `DMABufFormat`, `DMABufObject` and `DMABufReleaseFlag`.
* Removed custom encode/decode methods in `DMABufObject`.
* Fixed argument coder templates in `Encoder.h` and `Decoder.h` by
  removing unnecessary `void` parameters.
* Updated `CMakeLists.txt` in WebCore and WebKit to include DMABuf
  serialization files.

* Source/WebCore/CMakeLists.txt:
* Source/WebCore/platform/graphics/gbm/DMABufColorSpace.h:
* Source/WebCore/platform/graphics/gbm/DMABufColorSpace.serialization.in: Added.
* Source/WebCore/platform/graphics/gbm/DMABufFormat.h:
(WebCore::DMABufFormat::Plane::Plane):
* Source/WebCore/platform/graphics/gbm/DMABufFormat.serialization.in: Added.
* Source/WebCore/platform/graphics/gbm/DMABufObject.h:
(WebCore::DMABufObject::DMABufObject): Deleted.
(WebCore::DMABufObject::encode): Deleted.
(WebCore::DMABufObject::decode): Deleted.
* Source/WebCore/platform/graphics/gbm/DMABufObject.serialization.in: Added.
* Source/WebCore/platform/graphics/gbm/DMABufReleaseFlag.h:
(WebCore::DMABufReleaseFlag::DMABufReleaseFlag):
* Source/WebCore/platform/graphics/gbm/DMABufReleaseFlag.serialization.in: Added.
* Source/WebKit/CMakeLists.txt:
* Source/WebKit/Platform/IPC/Decoder.h:
(IPC::Decoder::decode):
* Source/WebKit/Platform/IPC/Encoder.h:

4b24153

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	❌ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2024-05-17T19:40:49Z

EWS run on previous version of this PR (hash 9903d05)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	🛠 mac	🛠 wpe	~~🛠 wincairo~~
🧪 bindings	🛠 ios-sim	~~🛠 mac-AS-debug~~	🧪 wpe-wk2	~~🧪 wincairo-tests~~
🧪 webkitperl	🧪 ios-wk2	🧪 api-mac	🧪 api-wpe
	🧪 ios-wk2-wpt	🧪 mac-wk1	🛠 wpe-cairo
	🧪 api-ios	🧪 mac-wk2	🛠 gtk
	~~🛠 tv~~	~~🧪 mac-AS-debug-wk2~~	🧪 gtk-wk2
	~~🛠 tv-sim~~	🧪 mac-wk2-stress	🧪 api-gtk
	~~🛠 watch~~
	~~🛠 watch-sim~~

psaavedra · 2024-05-17T19:44:31Z

Motivation:

A recent commit (https://commits.webkit.org/278057@main) breaks the WPEWebKit build when GPU_PROCESS=ON with this error in Source/WebKit/Platform/IPC/Encoder.h:

/sources/wpewebkit/Source/WebKit/Platform/IPC/Encoder.h:80:60: error: incomplete type 'IPC::ArgumentCoder<WebCore::DMABufObject, void>' used in nested name specifier
   80 |         ArgumentCoder<std::remove_cvref_t<T>, void>::encode(*this, std::forward<T>(t));
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~

webkit-early-warning-system · 2024-05-17T19:58:02Z

EWS run on previous version of this PR (hash eb7f9f6)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	🛠 mac	❌ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	⏳ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	🧪 mac-wk1	❌ 🛠 wpe-cairo
	❌ 🧪 api-ios	🧪 mac-wk2	❌ 🛠 gtk
	~~🛠 tv~~	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	~~🛠 tv-sim~~	🧪 mac-wk2-stress	❌ 🧪 api-gtk
	~~🛠 watch~~
	~~🛠 watch-sim~~

aperezdc

Patch looks nice overall, I only have a couple of doubts but those might be because I have not touched much the new autogenerated serialization stuff. That's why it would be better someone else checks this as well—maybe @csaavedra, as he has been doing serialization patches lately?

aperezdc · 2024-05-17T20:26:13Z

Source/WebCore/platform/graphics/gbm/DMABufColorSpace.h

@@ -1,6 +1,6 @@
 /*
 * Copyright (C) 2022 Metrological Group B.V.
- * Copyright (C) 2022 Igalia S.L.
+ * Copyright (C) 2024 Igalia S.L.


It's not technically needed to update copyright years but when we do, typically we use ranges:

Suggested change

* Copyright (C) 2024 Igalia S.L.

* Copyright (C) 2022-2024 Igalia S.L.

aperezdc · 2024-05-17T20:29:45Z

Source/WebCore/platform/graphics/gbm/DMABufFormat.h

@@ -126,6 +126,12 @@ struct DMABufFormat {
            , verticalSubsampling(PlaneDefinitionType::verticalSubsampling)
        { }

+        Plane(const FourCC& fourcc, const unsigned& hsValue, const unsigned& vsValue)


The constructor used during deserialization could be made private by adding a friend statement like this:

friend struct IPC::ArgumentCoder<Plane, void>;

as part of the struct Plane declaration.

aperezdc · 2024-05-17T20:31:24Z

Source/WebCore/platform/graphics/gbm/DMABufObject.h

@@ -40,20 +40,6 @@
 namespace WebCore {

 struct DMABufObject {
-    WTF_MAKE_NONCOPYABLE(DMABufObject);


Why do we need to remove WTF_MAKE_NONCOPYABLE() here? As far as I tried, the autogenerated serialization code can deal with non-copyable objects.

Also the generated code uses move semantics, so if this is getting copied somewhere, that should be fixed instead.

aperezdc · 2024-05-17T20:33:45Z

Source/WebKit/Platform/IPC/Decoder.h

-        std::optional<T> t { ArgumentCoder<std::remove_cvref_t<T>, void>::decode(*this) };
+        std::optional<T> t { ArgumentCoder<std::remove_cvref_t<T>>::decode(*this) };


I'm surprised this is needed. While working on #27313 one of the WIP versions of the patch added a new .serialization.in and this did not need to be changed 🤔

The signature of the encode methods autogenerated change a bit:

In file included from sources/wpewebkit/Source/WebKit/Shared/WebPreferencesStore.h:29, from sources/wpewebkit/Source/WebKit/UIProcess/WebPreferences.h:31, from wpewebkit-2.45.upstream-20240511/DerivedSources/WebKit/WebPreferencesFeatures.cpp:29: sources/wpewebkit/Source/WebKit/Platform/IPC/Encoder.h: In member function 'IPC::Encoder& IPC::Encoder::operator<<(T&&)': sources/wpewebkit/Source/WebKit/Platform/IPC/Encoder.h:80:46: error: wrong number of template arguments (2, should be 1) 80 | ArgumentCoder<std::remove_cvref_t<T, void>>::encode(*this, std::forward<T>(t)); | ^~~~ In file included from recipe-sysroot/usr/include/c++/13.2.0/bits/stl_pair.h:60, from recipe-sysroot/usr/include/c++/13.2.0/bits/stl_algobase.h:64, from recipe-sysroot/usr/include/c++/13.2.0/algorithm:60, from sources/wpewebkit/Source/WebKit/WebKit2Prefix.h:60, from <command-line>: recipe-sysroot/usr/include/c++/13.2.0/type_traits:3442:11: note: provided for 'template<class _Tp> using std::remove_cvref_t = typename std::remove_cvref::type' 3442 | using remove_cvref_t = typename remove_cvref<_Tp>::type; | ^~~~~~~~~~~~~~ sources/wpewebkit/Source/WebKit/Platform/IPC/Encoder.h:80:50: error: template argument 1 is invalid 80 | ArgumentCoder<std::remove_cvref_t<T, void>>::encode(*this, std::forward<T>(t)); | ^~ sources/wpewebkit/Source/WebKit/Platform/IPC/Encoder.h:80:86: error: expression list treated as compound expression in initializer [-fpermissive] 80 | ArgumentCoder<std::remove_cvref_t<T, void>>::encode(*this, std::forward<T>(t)); | ^

However it seems this is an issue for the Apple ports:

In file included from /Volumes/Data/worker/macOS-Ventura-Release-Build-EWS/build/WebKitBuild/Release/DerivedSources/TestWebKitAPI/unified-sources/UnifiedSource40-mm.mm:3: In file included from /Volumes/Data/worker/macOS-Ventura-Release-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:29: /Volumes/Data/worker/macOS-Ventura-Release-Build-EWS/build/Source/WebKit/Platform/IPC/Encoder.h:80:9: error: too few template arguments for class template 'ArgumentCoder'

I don't think you should do this change.

webkit-early-warning-system · 2024-05-17T20:38:02Z

EWS run on previous version of this PR (hash 75ae8d9)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	❌ 🛠 watch
	❌ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=274328 Reviewed by NOBODY (OOPS!). Explanation of why this fixes the bug (OOPS!). * Added new serialization description files for `DMABufColorSpace`, `DMABufFormat`, `DMABufObject` and `DMABufReleaseFlag`. * Removed custom encode/decode methods in `DMABufObject`. * Fixed argument coder templates in `Encoder.h` and `Decoder.h` by removing unnecessary `void` parameters. * Updated `CMakeLists.txt` in WebCore and WebKit to include DMABuf serialization files. * Source/WebCore/CMakeLists.txt: * Source/WebCore/platform/graphics/gbm/DMABufColorSpace.h: * Source/WebCore/platform/graphics/gbm/DMABufColorSpace.serialization.in: Added. * Source/WebCore/platform/graphics/gbm/DMABufFormat.h: (WebCore::DMABufFormat::Plane::Plane): * Source/WebCore/platform/graphics/gbm/DMABufFormat.serialization.in: Added. * Source/WebCore/platform/graphics/gbm/DMABufObject.h: (WebCore::DMABufObject::DMABufObject): Deleted. (WebCore::DMABufObject::encode): Deleted. (WebCore::DMABufObject::decode): Deleted. * Source/WebCore/platform/graphics/gbm/DMABufObject.serialization.in: Added. * Source/WebCore/platform/graphics/gbm/DMABufReleaseFlag.h: (WebCore::DMABufReleaseFlag::DMABufReleaseFlag): * Source/WebCore/platform/graphics/gbm/DMABufReleaseFlag.serialization.in: Added. * Source/WebKit/CMakeLists.txt: * Source/WebKit/Platform/IPC/Decoder.h: (IPC::Decoder::decode): * Source/WebKit/Platform/IPC/Encoder.h:

webkit-early-warning-system · 2024-05-18T06:21:48Z

EWS run on current version of this PR (hash 4b24153)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	❌ 🛠 watch
	❌ 🛠 watch-sim

csaavedra · 2024-05-18T06:30:41Z

Source/WebCore/CMakeLists.txt

+    platform/graphics/gbm/DMABufColorSpace.serialization.in
+    platform/graphics/gbm/DMABufFormat.serialization.in
+    platform/graphics/gbm/DMABufObject.serialization.in
+    platform/graphics/gbm/DMABufReleaseFlag.serialization.in


These files preferrably should go to WebKit/Shared/glib/ instead of WebCore. Also, you could just put all DMABuf definitions in a single file to avoid clutter (there is already one, merging that one too into a new ArgumentCodersDMABuf.serialization.in).

Does this also apply to .h files?

Not necessarily. I don't think you need to change those.

csaavedra · 2024-05-18T06:32:56Z

Source/WebCore/platform/graphics/gbm/DMABufColorSpace.serialization.in

+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+header: <WebCore/DMABufColorSpace.h>


You shouldn't need the header if the class for which a coder is being generated has a header with the exact same name and .h extension. header: is used when there are additional headers that need to be pulled and/or if the header has a different name (in which case you can use [CustomHeader] to prevent the default to be added).

csaavedra · 2024-05-18T06:39:53Z

Source/WebCore/platform/graphics/gbm/DMABufFormat.h

+namespace IPC {
+template<typename T, typename U> struct ArgumentCoder;
+}
+


You can simply include <wtf/ArgumentCoder.h> instead, but I don't think you need this, read below.

csaavedra · 2024-05-18T06:43:58Z

Source/WebCore/platform/graphics/gbm/DMABufFormat.h

+    private:
+        Plane(const FourCC& fourcc, const unsigned& hsValue, const unsigned& vsValue)
+            : fourcc(fourcc)
+            , horizontalSubsampling(hsValue)
+            , verticalSubsampling(vsValue)
+        { }
+
+        friend struct IPC::ArgumentCoder<Plane, void>;


You shouldn't need to add an explicit constructor since this is a struct and the data members are public, so aggregate initialization should work. If you use the same order in the serialization declaration as they are declared in the struct, the generated code should be able to create a new instance with something like Plane { WTFMove(arg1), WTFMove(arg2), WTFMove(arg3) }.

AFAIK, in c++, structs can indeed benefit from aggregate initialization if they meet certain conditions like no user-provided or inherited constructors, no private or protected non-static data members, no virtual functions, and no virtual, private, or protected base classes.

However, the struct Plane does not qualify for aggregate initialization because it includes a user-provided constructor.

struct Plane { Plane() = default; template<typename PlaneDefinitionType> Plane(const PlaneDefinitionType&) : fourcc(PlaneDefinitionType::fourcc) , horizontalSubsampling(PlaneDefinitionType::horizontalSubsampling) , verticalSubsampling(PlaneDefinitionType::verticalSubsampling) { } ...

csaavedra · 2024-05-18T06:47:28Z

Source/WebCore/platform/graphics/gbm/DMABufFormat.serialization.in

+header: <WebCore/DMABufFormat.h>
+struct WebCore::DMABufFormat {


Same as above regarding header:.

csaavedra · 2024-05-18T06:48:32Z

Source/WebCore/platform/graphics/gbm/DMABufObject.serialization.in

+header: <WebCore/DMABufObject.h>
+[CustomHeader] struct WebCore::DMABufObject {


Same as above regarding header:.

csaavedra · 2024-05-18T06:49:39Z

Source/WebKit/Platform/IPC/Decoder.h

-        std::optional<T> t { ArgumentCoder<std::remove_cvref_t<T>, void>::decode(*this) };
+        std::optional<T> t { ArgumentCoder<std::remove_cvref_t<T>>::decode(*this) };


I don't think you should do this change.

csaavedra · 2024-05-18T06:49:53Z

Source/WebKit/Platform/IPC/Encoder.h

-        ArgumentCoder<std::remove_cvref_t<T>, void>::encode(*this, std::forward<T>(t));
+        ArgumentCoder<std::remove_cvref_t<T>>::encode(*this, std::forward<T>(t));


I don't think you should do this change.

csaavedra · 2024-05-18T06:50:03Z

Source/WebCore/platform/graphics/gbm/DMABufReleaseFlag.serialization.in

+header: <WebCore/DMABufReleaseFlag.h>
+struct WebCore::DMABufReleaseFlag {


Same as above regarding header:.

csaavedra · 2024-05-18T06:51:31Z

Source/WebCore/platform/graphics/gbm/DMABufObject.h

@@ -40,20 +40,6 @@
 namespace WebCore {

 struct DMABufObject {
-    WTF_MAKE_NONCOPYABLE(DMABufObject);


Also the generated code uses move semantics, so if this is getting copied somewhere, that should be fixed instead.

psaavedra requested a review from cdumez as a code owner May 17, 2024 19:40

psaavedra self-assigned this May 17, 2024

psaavedra added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label May 17, 2024

psaavedra force-pushed the eng/GLIB-Generate-serialization-for-DMABuf-classes branch from 9903d05 to eb7f9f6 Compare May 17, 2024 19:57

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 17, 2024

aperezdc reviewed May 17, 2024

View reviewed changes

aperezdc requested review from csaavedra and a team May 17, 2024 20:36

psaavedra removed the merging-blocked Applied to prevent a change from being merged label May 17, 2024

psaavedra force-pushed the eng/GLIB-Generate-serialization-for-DMABuf-classes branch from eb7f9f6 to 75ae8d9 Compare May 17, 2024 20:37

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 17, 2024

psaavedra removed the merging-blocked Applied to prevent a change from being merged label May 18, 2024

psaavedra force-pushed the eng/GLIB-Generate-serialization-for-DMABuf-classes branch from 75ae8d9 to 4b24153 Compare May 18, 2024 06:21

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 18, 2024

csaavedra requested changes May 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GLIB] Generate serialization for DMABuf classes #28725

[GLIB] Generate serialization for DMABuf classes #28725

psaavedra commented May 17, 2024 •

edited by webkit-early-warning-system

webkit-early-warning-system commented May 17, 2024 •

edited

psaavedra commented May 17, 2024

webkit-early-warning-system commented May 17, 2024 •

edited

aperezdc left a comment

aperezdc May 17, 2024

aperezdc May 17, 2024 •

edited

aperezdc May 17, 2024

csaavedra May 18, 2024

aperezdc May 17, 2024

psaavedra May 18, 2024

psaavedra May 18, 2024

csaavedra May 18, 2024

webkit-early-warning-system commented May 17, 2024 •

edited

webkit-early-warning-system commented May 18, 2024 •

edited

csaavedra May 18, 2024 •

edited

psaavedra May 21, 2024 •

edited

csaavedra May 21, 2024

csaavedra May 18, 2024

csaavedra May 18, 2024

csaavedra May 18, 2024

psaavedra May 21, 2024

csaavedra May 18, 2024

csaavedra May 18, 2024

csaavedra May 18, 2024

csaavedra May 18, 2024

csaavedra May 18, 2024

csaavedra May 18, 2024

	* Copyright (C) 2024 Igalia S.L.
	* Copyright (C) 2022-2024 Igalia S.L.

		std::optional<T> t { ArgumentCoder<std::remove_cvref_t<T>, void>::decode(*this) };
		std::optional<T> t { ArgumentCoder<std::remove_cvref_t<T>>::decode(*this) };

		header: <WebCore/DMABufFormat.h>
		struct WebCore::DMABufFormat {

		header: <WebCore/DMABufObject.h>
		[CustomHeader] struct WebCore::DMABufObject {

		ArgumentCoder<std::remove_cvref_t<T>, void>::encode(*this, std::forward<T>(t));
		ArgumentCoder<std::remove_cvref_t<T>>::encode(*this, std::forward<T>(t));

		header: <WebCore/DMABufReleaseFlag.h>
		struct WebCore::DMABufReleaseFlag {

[GLIB] Generate serialization for DMABuf classes #28725

Are you sure you want to change the base?

[GLIB] Generate serialization for DMABuf classes #28725

Conversation

psaavedra commented May 17, 2024 • edited by webkit-early-warning-system

webkit-early-warning-system commented May 17, 2024 • edited

psaavedra commented May 17, 2024

webkit-early-warning-system commented May 17, 2024 • edited

aperezdc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aperezdc May 17, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webkit-early-warning-system commented May 17, 2024 • edited

webkit-early-warning-system commented May 18, 2024 • edited

csaavedra May 18, 2024 • edited

Choose a reason for hiding this comment

psaavedra May 21, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

psaavedra commented May 17, 2024 •

edited by webkit-early-warning-system

webkit-early-warning-system commented May 17, 2024 •

edited

webkit-early-warning-system commented May 17, 2024 •

edited

aperezdc May 17, 2024 •

edited

webkit-early-warning-system commented May 17, 2024 •

edited

webkit-early-warning-system commented May 18, 2024 •

edited

csaavedra May 18, 2024 •

edited

psaavedra May 21, 2024 •

edited