Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GStreamer] Minor cleanups in GstMappedFrame class #28708

Merged
merged 1 commit into from
May 20, 2024

Conversation

philn
Copy link
Member

@philn philn commented May 17, 2024

04a4f4a

[GStreamer] Minor cleanups in GstMappedFrame class
https://bugs.webkit.org/show_bug.cgi?id=274312

Reviewed by Xabier Rodriguez-Calvar.

There is no need for a m_isValid boolean attribute because the buffer field on the GstVideoFrame can
be checked instead.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:
(WebCore::GstMappedFrame::GstMappedFrame):
(WebCore::GstMappedFrame::~GstMappedFrame):
(WebCore::GstMappedFrame::get):
(WebCore::GstMappedFrame::ComponentData const):
(WebCore::GstMappedFrame::ComponentStride const):
(WebCore::GstMappedFrame::info):
(WebCore::GstMappedFrame::width const):
(WebCore::GstMappedFrame::height const):
(WebCore::GstMappedFrame::format const):
(WebCore::GstMappedFrame::planeData const):
(WebCore::GstMappedFrame::planeStride const):
(WebCore::GstMappedFrame::isValid const):
(WebCore::GstMappedFrame::operator bool const):
(WebCore::GstMappedFrame::operator! const):

Canonical link: https://commits.webkit.org/278992@main

d44ba45

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings   πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2   πŸ§ͺ wincairo-tests
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
❌ πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  wpe-cairo
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2   πŸ§ͺ gtk-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2-stress βœ… πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@philn philn self-assigned this May 17, 2024
@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label May 17, 2024
@philn philn requested a review from calvaris May 17, 2024 14:59
@philn philn added the merge-queue Applied to send a pull request to merge-queue label May 20, 2024
https://bugs.webkit.org/show_bug.cgi?id=274312

Reviewed by Xabier Rodriguez-Calvar.

There is no need for a m_isValid boolean attribute because the buffer field on the GstVideoFrame can
be checked instead.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:
(WebCore::GstMappedFrame::GstMappedFrame):
(WebCore::GstMappedFrame::~GstMappedFrame):
(WebCore::GstMappedFrame::get):
(WebCore::GstMappedFrame::ComponentData const):
(WebCore::GstMappedFrame::ComponentStride const):
(WebCore::GstMappedFrame::info):
(WebCore::GstMappedFrame::width const):
(WebCore::GstMappedFrame::height const):
(WebCore::GstMappedFrame::format const):
(WebCore::GstMappedFrame::planeData const):
(WebCore::GstMappedFrame::planeStride const):
(WebCore::GstMappedFrame::isValid const):
(WebCore::GstMappedFrame::operator bool const):
(WebCore::GstMappedFrame::operator! const):

Canonical link: https://commits.webkit.org/278992@main
@webkit-commit-queue
Copy link
Collaborator

Committed 278992@main (04a4f4a): https://commits.webkit.org/278992@main

Reviewed commits have been landed. Closing PR #28708 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 04a4f4a into WebKit:main May 20, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 20, 2024
@philn philn deleted the eng/274312 branch May 20, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
4 participants