Stop using const char* in string concatenations
#28707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdumez
added
the
WebCore Misc.
webkit-ews-buildbot
added
the
merging-blocked
cdumez
force-pushed
the
274297_concatenations_no_const_char
branch
from
530986c
to
b981013
Compare
|
EWS run on previous version of this PR (hash b981013) |
🛠 ios
🛠 mac
|
EWS run on previous version of this PR (hash 530986c) |
webkit-ews-buildbot
added
the
merging-blocked
cdumez
force-pushed
the
274297_concatenations_no_const_char
branch
from
b981013
to
e591e10
Compare
|
EWS run on previous version of this PR (hash e591e10) |
cdumez
force-pushed
the
274297_concatenations_no_const_char
branch
from
e591e10
to
11bec9b
Compare
|
EWS run on previous version of this PR (hash 11bec9b) |
cdumez
force-pushed
the
274297_concatenations_no_const_char
branch
from
11bec9b
to
5455c0d
Compare
|
EWS run on previous version of this PR (hash 5455c0d) |
webkit-ews-buildbot
added
the
merging-blocked
cdumez
force-pushed
the
274297_concatenations_no_const_char
branch
from
5455c0d
to
2a15ff3
Compare
|
EWS run on previous version of this PR (hash 2a15ff3) |
cdumez
force-pushed
the
274297_concatenations_no_const_char
branch
from
2a15ff3
to
e78c19e
Compare
|
EWS run on previous version of this PR (hash e78c19e) |
webkit-ews-buildbot
added
the
merging-blocked
cdumez
force-pushed
the
274297_concatenations_no_const_char
branch
from
e78c19e
to
84ecf61
Compare
|
EWS run on previous version of this PR (hash 84ecf61) |
webkit-ews-buildbot
added
the
merging-blocked
cdumez
force-pushed
the
274297_concatenations_no_const_char
branch
from
84ecf61
to
13db5ec
Compare
|
EWS run on previous version of this PR (hash 13db5ec) |
webkit-ews-buildbot
added
the
merging-blocked
cdumez
force-pushed
the
274297_concatenations_no_const_char
branch
from
9959c74
to
57c8ea1
Compare
|
EWS run on previous version of this PR (hash 57c8ea1) |
cdumez
force-pushed
the
274297_concatenations_no_const_char
branch
from
57c8ea1
to
9e1a4fe
Compare
|
EWS run on previous version of this PR (hash 9e1a4fe) |
webkit-ews-buildbot
added
the
merging-blocked
cdumez
force-pushed
the
274297_concatenations_no_const_char
branch
from
9e1a4fe
to
a4ea6b9
Compare
|
EWS run on previous version of this PR (hash a4ea6b9) |
cdumez
requested review from
zdobersek,
a team,
philn,
carlosgcampos,
b-weinstein,
xeenon and
JonWBedard
as code owners
darinadler
approved these changes
May 19, 2024
Comment on lines
433
to
436
| if (!micro) | ||
| return makeString(String::number(major), ".", String::number(minor)); | ||
| return makeString(String::number(major), '.', String::number(minor)); | ||
|
|
||
| return makeString(String::number(major), ".", String::number(minor), ".", String::number(micro)); | ||
| return makeString(String::number(major), '.', String::number(minor), '.', String::number(micro)); |
There was a problem hiding this comment.
Don’t need String::number here.
| } | ||
| } | ||
|
|
||
| #if USE(LIBDRM) | ||
| if (strcmp(policy, "never")) { | ||
| if (strcmp(policy.characters(), "never")) { |
There was a problem hiding this comment.
Kind of wish we had an != we could use here instead.
There was a problem hiding this comment.
Actually, I believe we do for ASCIILiteral. I'll update.
| @@ -429,7 +429,7 @@ static void interceptMarketplaceKitNavigation(Ref<API::NavigationAction>&& actio | |||
| if (!sourceFrameID || !weakPage) | |||
| return; | |||
|
|
|||
| weakPage->addConsoleMessage(*sourceFrameID, MessageSource::Network, MessageLevel::Error, makeString("Can't handle MarketplaceKit link ", url.string().utf8().data(), " due to error: "_s, error)); | |||
| weakPage->addConsoleMessage(*sourceFrameID, MessageSource::Network, MessageLevel::Error, makeString("Can't handle MarketplaceKit link "_s, url.string().utf8().span(), " due to error: "_s, error)); | |||
There was a problem hiding this comment.
I don’t think we should convert this to UTF-8 and back to Latin-1/UTF-16, unless there is some benefit to that I am missing. I think we can just write url.string() instead of url.string().utf8().span().
| builder.append('\n', prefix, m_entries[i]->loggingString()); | ||
| } | ||
|
|
||
| return makeString("\n", builder.toString()); | ||
| return makeString('\n', builder.toString()); |
There was a problem hiding this comment.
Lets put the '\n' into the StringBuilder at the start of the function and avoid this expensive prepend operation.
| @@ -1097,7 +1097,7 @@ void WebProcessPool::processDidFinishLaunching(WebProcessProxy& process) | |||
| if (m_memorySamplerEnabled) { | |||
| SandboxExtension::Handle sampleLogSandboxHandle; | |||
| WallTime now = WallTime::now(); | |||
| auto sampleLogFilePath = makeString("WebProcess", static_cast<unsigned long long>(now.secondsSinceEpoch().seconds()), "pid", process.processID()); | |||
| auto sampleLogFilePath = makeString("WebProcess"_s, static_cast<unsigned long long>(now.secondsSinceEpoch().seconds()), "pid"_s, process.processID()); | |||
There was a problem hiding this comment.
I wonder if we could write this as now.secondsSinceEpoch().secondsAs<uint64_t>() instead?
| @@ -1948,7 +1948,7 @@ static void runTest(const std::string& inputLine) | |||
| if (!testPath) | |||
| testPath = [url absoluteString]; | |||
|
|
|||
| auto message = makeString("CRASHING TEST: ", testPath.UTF8String); | |||
| auto message = makeString("CRASHING TEST: "_s, span(testPath.UTF8String)); | |||
There was a problem hiding this comment.
Can we just pass in testPath and let the NSString capabilities of makeString take care of it, instead of calling UTF8String? In fact, this existing code seems like it will reinterpret UTF-8 characters as Latin-1 and then convert back to UTF-8, so that might even fix a non-ASCII characters bug.
There was a problem hiding this comment.
/Volumes/Data/worker/macOS-Sonoma-Debug-Build-EWS/build/WebKitBuild/Debug/usr/local/include/wtf/text/StringConcatenate.h:534:38: error: implicit instantiation of undefined template 'WTF::StringTypeAdapter<NSString *>'
Doesn't seem like makeString() plays nicely with NSString* ?
There was a problem hiding this comment.
Oh, I'll try to include StringConcatenateCF.h
| @@ -300,7 +300,7 @@ static String attributesOfElement(AccessibilityUIElement& element) | |||
|
|
|||
| String description = element.description()->string(); | |||
| if (!description.isEmpty()) | |||
| builder.append(description.utf8().data(), '\n'); | |||
| builder.append(description.utf8().span(), '\n'); | |||
There was a problem hiding this comment.
How about just description instead of description.utf8().span()? The existing code seems to convert to UTF-8 then back as Latin-1, for no good reason.
| @@ -905,29 +905,29 @@ JSRetainPtr<JSStringRef> AccessibilityUIElement::computedRoleString() | |||
| JSRetainPtr<JSStringRef> AccessibilityUIElement::title() | |||
| { | |||
| m_element->updateBackingStore(); | |||
| auto titleValue = makeString("AXTitle: ", String::fromUTF8(m_element->name().span())); | |||
| auto titleValue = makeString("AXTitle: "_s, String::fromUTF8(m_element->name().span())); | |||
There was a problem hiding this comment.
No need to use String::fromUTF8 here. Very confusing!
| return OpaqueJSString::tryCreate(titleValue).leakRef(); | ||
| } | ||
|
|
||
| JSRetainPtr<JSStringRef> AccessibilityUIElement::description() | ||
| { | ||
| m_element->updateBackingStore(); | ||
| auto descriptionValue = makeString("AXDescription: ", String::fromUTF8(m_element->description().span())); | ||
| auto descriptionValue = makeString("AXDescription: "_s, String::fromUTF8(m_element->description().span())); |
There was a problem hiding this comment.
No need to use String::fromUTF8 here. Very confusing!
| @@ -953,14 +953,14 @@ JSRetainPtr<JSStringRef> AccessibilityUIElement::stringValue() | |||
| // Tests expect the combo box to expose the selected element name as the string value. | |||
| if (auto menu = childAtIndex(0)) { | |||
| if (auto* selectedChild = menu->m_element->selectedChild(0)) | |||
| return OpaqueJSString::tryCreate(makeString("AXValue: ", String::fromUTF8(selectedChild->name().span()))).leakRef(); | |||
| return OpaqueJSString::tryCreate(makeString("AXValue: "_s, String::fromUTF8(selectedChild->name().span()))).leakRef(); | |||
There was a problem hiding this comment.
No need to use String::fromUTF8 here. Very confusing!
cdumez
force-pushed
the
274297_concatenations_no_const_char
branch
from
a4ea6b9
to
8bf6465
Compare
|
EWS run on previous version of this PR (hash 8bf6465) |
cdumez
force-pushed
the
274297_concatenations_no_const_char
branch
from
8bf6465
to
7e079d4
Compare
|
EWS run on current version of this PR (hash 7e079d4) |
cdumez
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=274297 Reviewed by Darin Adler. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WTF/wtf/text/StringConcatenate.h: * Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCaptureSource.cpp: (WebCore::GStreamerAudioCaptureSource::create): * Source/WebCore/platform/mediastream/gstreamer/GStreamerDisplayCaptureDeviceManager.cpp: (WebCore::GStreamerDisplayCaptureDeviceManager::computeCaptureDevices): (WebCore::GStreamerDisplayCaptureDeviceManager::createDisplayCaptureSource): * Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: * Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp: (WebCore::GStreamerVideoCaptureSource::create): * Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp: (WebCore::RealtimeIncomingSourceGStreamer::unregisterClientLocked): (WebCore::RealtimeIncomingSourceGStreamer::handleUpstreamEvent): (WebCore::RealtimeIncomingSourceGStreamer::handleUpstreamQuery): * Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp: (WebCore::RealtimeOutgoingAudioSourceGStreamer::RealtimeOutgoingAudioSourceGStreamer): * Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp: (WebCore::RealtimeOutgoingVideoSourceGStreamer::RealtimeOutgoingVideoSourceGStreamer): * Source/WebKit/NetworkProcess/BackgroundFetchLoad.cpp: * Source/WebKit/NetworkProcess/Classifier/ITPThirdPartyDataForSpecificFirstParty.cpp: (WebKit::ITPThirdPartyDataForSpecificFirstParty::toString const): * Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp: (WebKit::domainsToString): (WebKit::buildList): (WebKit::ResourceLoadStatisticsStore::debugLogDomainsInBatches): (WebKit::ResourceLoadStatisticsStore::deleteTable): (WebKit::ResourceLoadStatisticsStore::ensureAndMakeDomainList): (WebKit::ResourceLoadStatisticsStore::insertDomainRelationshipList): (WebKit::ResourceLoadStatisticsStore::incrementRecordsDeletedCountForDomains): (WebKit::ResourceLoadStatisticsStore::markAsPrevalentIfHasRedirectedToPrevalent): (WebKit::ResourceLoadStatisticsStore::findNotVeryPrevalentResources): (WebKit::ResourceLoadStatisticsStore::grandfatherDataForDomains): (WebKit::ResourceLoadStatisticsStore::logFrameNavigation): (WebKit::ResourceLoadStatisticsStore::setDomainsAsPrevalent): (WebKit::ResourceLoadStatisticsStore::updateCookieBlocking): (WebKit::ResourceLoadStatisticsStore::clearGrandfathering): (WebKit::ResourceLoadStatisticsStore::registrableDomainsToDeleteOrRestrictWebsiteDataFor): (WebKit::ResourceLoadStatisticsStore::pruneStatisticsIfNeeded): * Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.h: * Source/WebKit/NetworkProcess/DatabaseUtilities.cpp: (WebKit::insertDistinctValuesInTableStatement): (WebKit::DatabaseUtilities::migrateDataToNewTablesIfNecessary): (WebKit::DatabaseUtilities::columnsForTable): (WebKit::DatabaseUtilities::addMissingColumnToTable): * Source/WebKit/NetworkProcess/EarlyHintsResourceLoader.cpp: (WebKit::EarlyHintsResourceLoader::startPreconnectTask): * Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp: (WebKit::NetworkCORSPreflightChecker::willPerformHTTPRedirection): * Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp: (WebKit::NetworkLoadChecker::checkRedirection): (WebKit::NetworkLoadChecker::continueCheckingRequest): * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::newTestingSession): * Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::shouldInterruptLoadForCSPFrameAncestorsOrXFrameOptions): (WebKit::NetworkResourceLoader::shouldInterruptNavigationForCrossOriginEmbedderPolicy): (WebKit::NetworkResourceLoader::shouldInterruptWorkerLoadForCrossOriginEmbedderPolicy): * Source/WebKit/NetworkProcess/cache/NetworkCache.cpp: (WebKit::NetworkCache::Cache::dumpContentsToFile): * Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm: (-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]): * Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm: (WebKit::NetworkProcess::initializeSandbox): * Source/WebKit/NetworkProcess/storage/BackgroundFetchStoreManager.cpp: (WebKit::BackgroundFetchStoreManager::clearAllFetches): (WebKit::BackgroundFetchStoreManager::storeFetchAfterQuotaCheck): (WebKit::createFetchResponseBodyFile): * Source/WebKit/NetworkProcess/storage/LocalStorageManager.cpp: (WebKit::originToFileName): * Source/WebKit/Platform/IPC/win/ConnectionWin.cpp: (IPC::createServerAndClientIdentifiers): * Source/WebKit/Platform/cocoa/WebPrivacyHelpers.mm: (WebKit::LinkDecorationFilteringController::updateStrings): (WebKit::requestLinkDecorationFilteringData): (WebKit::configureForAdvancedPrivacyProtections): * Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesStoreDefaultsMap.cpp.erb: * Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm: (WebKit::AuxiliaryProcess::didReceiveInvalidMessage): * Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm: (WebKit::checkFrameworkVersion): * Source/WebKit/Shared/Gamepad/GamepadData.cpp: (WebKit::GamepadData::loggingString const): * Source/WebKit/Shared/WebBackForwardListItem.cpp: (WebKit::WebBackForwardListItem::loggingString): * Source/WebKit/Shared/WebMemorySampler.cpp: (WebKit::WebMemorySampler::writeHeaders): * Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm: (WebKit::setAndSerializeSandboxParameters): * Source/WebKit/Shared/win/WebEventFactory.cpp: (WebKit::keyIdentifierFromEvent): * Source/WebKit/Shared/wpe/WebKeyboardEventWPE.cpp: (WebKit::WebKeyboardEvent::keyIdentifierForWPEKeyval): * Source/WebKit/UIProcess/API/APINavigation.cpp: (API::Navigation::loggingString const): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm: (dumpCALayer): * Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp: (webkitPrintOperationPreparePrint): * Source/WebKit/UIProcess/API/ios/WKWebViewTestingIOS.mm: (allowListedClassToString): (dumpUIView): * Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp: (WebKit::WebAutomationSession::createBrowsingContext): (WebKit::WebAutomationSession::setWindowFrameOfBrowsingContext): (WebKit::fileCanBeAcceptedForUpload): (WebKit::WebAutomationSession::resolveChildFrameHandle): (WebKit::WebAutomationSession::computeElementLayout): (WebKit::WebAutomationSession::setFilesToSelectForFileUpload): (WebKit::WebAutomationSession::setFilesForInputFileUpload): (WebKit::WebAutomationSession::addSingleCookie): (WebKit::WebAutomationSession::setSessionPermissions): (WebKit::WebAutomationSession::removeVirtualAuthenticator): (WebKit::WebAutomationSession::addVirtualAuthenticatorCredential): (WebKit::WebAutomationSession::removeVirtualAuthenticatorCredential): (WebKit::WebAutomationSession::removeAllVirtualAuthenticatorCredentials): (WebKit::WebAutomationSession::setVirtualAuthenticatorUserVerified): (WebKit::WebAutomationSession::performMouseInteraction): (WebKit::WebAutomationSession::performKeyboardInteractions): (WebKit::WebAutomationSession::performInteractionSequence): * Source/WebKit/UIProcess/Automation/WebAutomationSessionMacros.h: * Source/WebKit/UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.mm: (WebKit::SubFrameSOAuthorizationSession::shouldInterruptLoadForCSPFrameAncestorsOrXFrameOptions): * Source/WebKit/UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm: (WebKit::reportAnErrorURL): (WebKit::malwareDetailsURL): * Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm: (WebKit::WebPasteboardProxy::testIPCSharedMemory): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::WebExtensionContext): (WebKit::WebExtensionContext::load): (WebKit::WebExtensionContext::setBaseURL): * Source/WebKit/UIProcess/Inspector/WebInspectorUtilities.cpp: (WebKit::defaultInspectorPageGroupIdentifierForPage): * Source/WebKit/UIProcess/Inspector/glib/RemoteInspectorClient.cpp: (WebKit::RemoteInspectorClient::setBackendCommands): * Source/WebKit/UIProcess/Inspector/socket/RemoteInspectorClient.cpp: (WebKit::RemoteInspectorClient::setBackendCommands): * Source/WebKit/UIProcess/Inspector/socket/RemoteInspectorProtocolHandler.cpp: (WebKit::RemoteInspectorProtocolHandler::updateTargetList): * Source/WebKit/UIProcess/Inspector/win/WebInspectorUIProxyWin.cpp: (WebKit::WebInspectorUIProxy::showSavePanelForSingleFile): * Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp: (WebKit::effectiveApplicationId): * Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp: (WebKit::XDGDBusProxy::dbusSessionProxy): (WebKit::XDGDBusProxy::accessibilityProxy): * Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::requestStorageSpace): * Source/WebKit/UIProcess/ProcessThrottler.cpp: (WebKit::ProcessThrottler::assertionName const): * Source/WebKit/UIProcess/SuspendedPageProxy.cpp: (WebKit::SuspendedPageProxy::loggingString const): * Source/WebKit/UIProcess/ViewGestureController.cpp: (WebKit::ViewGestureController::SnapshotRemovalTracker::reset): (WebKit::ViewGestureController::SnapshotRemovalTracker::stopWaitingForEvent): (WebKit::ViewGestureController::SnapshotRemovalTracker::fireRemovalCallbackIfPossible): (WebKit::ViewGestureController::SnapshotRemovalTracker::startWatchdog): * Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm: (WebKit::LocalAuthenticator::makeCredential): (WebKit::LocalAuthenticator::continueMakeCredentialAfterReceivingLAContext): (WebKit::LocalAuthenticator::continueMakeCredentialAfterUserVerification): (WebKit::LocalAuthenticator::continueGetAssertionAfterUserVerification): * Source/WebKit/UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp: (WebKit::U2fAuthenticator::continueRegisterCommandAfterResponseReceived): (WebKit::U2fAuthenticator::continueBogusCommandExcludeCredentialsMatchAfterResponseReceived): (WebKit::U2fAuthenticator::continueBogusCommandNoCredentialsAfterResponseReceived): * Source/WebKit/UIProcess/WebBackForwardList.cpp: (WebKit::WebBackForwardList::loggingString): * Source/WebKit/UIProcess/WebPageGroup.cpp: (WebKit::pageGroupData): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::loadServiceWorker): * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::processDidFinishLaunching): (WebKit::WebProcessPool::startMemorySampler): * Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::platformSetNetworkParameters): * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::fetchDataAndApply): * Source/WebKit/UIProcess/geoclue/GeoclueGeolocationProvider.cpp: (WebKit::GeoclueGeolocationProvider::createPortalSession): (WebKit::GeoclueGeolocationProvider::startPortalSession): * Source/WebKit/UIProcess/win/WebPopupMenuProxyWin.cpp: (WebKit::WebPopupMenuProxyWin::debugDescription const): * Source/WebKit/WPEPlatform/wpe/wayland/WPEWaylandSHMPool.cpp: (WPE::createSharedMemory): * Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp: * Source/WebKit/WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp: (WebKit::uniqueWorldName): * Source/WebKit/WebProcess/Inspector/WebPageInspectorTarget.cpp: (WebKit::WebPageInspectorTarget::toTargetID): * Source/WebKit/WebProcess/Model/mac/ARKitInlinePreviewModelPlayerMac.mm: (WebKit::ARKitInlinePreviewModelPlayerMac::createPreviewsForModelWithURL): * Source/WebKit/WebProcess/Network/WebResourceLoader.cpp: (WebKit::WebResourceLoader::didFailServiceWorkerLoad): * Source/WebKit/WebProcess/Plugins/PDF/PDFIncrementalLoader.mm: (WebKit::PDFIncrementalLoader::receivedNonLinearizedPDFSentinel): (WebKit::PDFIncrementalLoader::incrementalPDFStreamDidFinishLoading): (WebKit::PDFIncrementalLoader::getResourceBytesAtPosition): (WebKit::PDFIncrementalLoader::streamLoaderDidStart): (WebKit::PDFIncrementalLoader::forgetStreamLoader): (WebKit::PDFIncrementalLoader::requestDidCompleteWithBytes): (WebKit::PDFIncrementalLoader::requestDidCompleteWithAccumulatedData): (WebKit::PDFIncrementalLoader::dataProviderGetBytesAtPosition): (WebKit::PDFIncrementalLoader::dataProviderGetByteRanges): * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm: (WebKit::PDFPluginBase::startByteRangeRequest): (WebKit::PDFPluginBase::debugDescription const): * Source/WebKit/WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp: (WebKit::WebResourceLoadObserver::statisticsForURL): * Source/WebKit/WebProcess/WebPage/Cocoa/WebCookieCacheCocoa.mm: (WebKit::WebCookieCache::inMemoryStorageSession): * Source/WebKit/WebProcess/WebPage/Cocoa/WebCookieJarCocoa.mm: (WebKit::WebCookieJar::cookiesInPartitionedCookieStorage const): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::getContentsAsString): * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformSetWebsiteDataStoreParameters): (WebKit::WebProcess::initializeSandbox): * Source/WebKit/webpushd/PushClientConnection.mm: (WebPushD::PushClientConnection::setDebugModeIsEnabled): (WebPushD::PushClientConnection::broadcastDebugMessage): * Source/WebKit/webpushd/PushService.mm: * Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb: * Tools/TestWebKitAPI/Tests/IPC/IPCTestUtilities.cpp: (TestWebKitAPI::ConnectionTestBase::teardownBase): * Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp: (TestWebKitAPI::TEST(StringBuilderTest, VariadicAppend)): * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: (TestWebKitAPI::TEST(WTF, StringConcatenate)): (TestWebKitAPI::TEST(WTF, StringConcatenate_Int)): (TestWebKitAPI::TEST(WTF, StringConcatenate_Unsigned)): (TestWebKitAPI::TEST(WTF, StringConcatenate_Float)): (TestWebKitAPI::TEST(WTF, StringConcatenate_Double)): (TestWebKitAPI::TEST(WTF, StringConcatenate_FormattedDoubleFixedPrecision)): (TestWebKitAPI::TEST(WTF, StringConcatenate_FormattedDoubleFixedWidth)): (TestWebKitAPI::TEST(WTF, StringConcatenate_Pad)): (TestWebKitAPI::TEST(WTF, StringConcatenate_Tuple)): * Tools/TestWebKitAPI/Tests/WTF/UUID.cpp: (TEST(WTF, TestUUIDVersion4MakeString)): * Tools/TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp: (ApplicationManifestParserTest::parseTopLevelProperty): (ApplicationManifestParserTest::parseIconFirstTopLevelProperty): (ApplicationManifestParserTest::parseIconFirstTopLevelPropertyForSrc): (ApplicationManifestParserTest::testScope): (ApplicationManifestParserTest::testId): * Tools/TestWebKitAPI/Tests/WebCore/DocumentOrder.cpp: (TestWebKitAPI::string): (TestWebKitAPI::typeStringSuffix): (TestWebKitAPI::allPositionTypeFailures): * Tools/TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: (TestWebKitAPI::createCommand): (TestWebKitAPI::TEST_F): * Tools/TestWebKitAPI/Tests/WebCore/HTTPHeaderField.cpp: (canonicalizeHTTPHeader): * Tools/TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: (TestWebKitAPI::TEST_F): * Tools/TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp: (TestWebKitAPI::TEST_F): * Tools/WebKitTestRunner/cocoa/CrashReporterInfo.mm: (WTR::setCrashReportApplicationSpecificInformationToURL): Canonical link: https://commits.webkit.org/278972@main
webkit-commit-queue
force-pushed
the
274297_concatenations_no_const_char
branch
from
7e079d4
to
1cf337e
Compare
|
Committed 278972@main (1cf337e): https://commits.webkit.org/278972@main Reviewed commits have been landed. Closing PR #28707 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1cf337e
7e079d4
🧪 wpe-wk2🧪 ios-wk2🧪 ios-wk2-wpt🧪 api-gtk