Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vita3k/interface: More detailed error message. #3279

Merged
merged 3 commits into from
May 20, 2024
Merged

Conversation

Croden1999
Copy link
Contributor

@Croden1999 Croden1999 commented Apr 22, 2024

About

  • vita3k/interface: More detailed error message.
  • gui/common_dialog: Add IsKeyPressed to the buttons.
  • app/app_init: Fix typos.
  • io/file: Add cstddef head file.

image
image

@Croden1999 Croden1999 force-pushed the window branch 2 times, most recently from cd75132 to 33a9cb2 Compare April 22, 2024 04:28
@Croden1999 Croden1999 changed the title vita3k/interface: Clearer instruction of the window. vita3k/interface: Clearer message of the window. Apr 22, 2024
@Croden1999 Croden1999 changed the title vita3k/interface: Clearer message of the window. vita3k/interface: Clearer message. Apr 22, 2024
@Croden1999 Croden1999 force-pushed the window branch 2 times, most recently from f74ca31 to 76ab8fb Compare April 22, 2024 09:06
vita3k/interface.cpp Outdated Show resolved Hide resolved
@Croden1999 Croden1999 changed the title vita3k/interface: Clearer message. vita3k/interface: More detailed error message. Apr 23, 2024
@Croden1999 Croden1999 force-pushed the window branch 2 times, most recently from 705d04f to 8e54725 Compare April 23, 2024 01:09
@github-actions github-actions bot added the app label Apr 23, 2024
@Croden1999 Croden1999 force-pushed the window branch 5 times, most recently from fe34e2f to c47969b Compare April 23, 2024 02:25
@Zangetsu38
Copy link
Contributor

Zangetsu38 commented Apr 23, 2024

remove gui part, is not need charge it, set lang variable inside one emuenv variable

@Croden1999 Croden1999 force-pushed the window branch 2 times, most recently from 8ffb907 to 069958b Compare April 24, 2024 06:04
@Croden1999
Copy link
Contributor Author

Mr. @EXtremeExploit , could you check the bulid?

@nn9dev
Copy link
Contributor

nn9dev commented May 20, 2024

i have no idea what could be causing it, but simply changing all of the instances of size_t to std::size_t in the file vita3k/io/include/io/file.h makes it build just fine on Linux. diff attached.
diff.txt

@github-actions github-actions bot added the io Related to io/filesystem label May 20, 2024
@Croden1999
Copy link
Contributor Author

i have no idea what could be causing it, but simply changing all of the instances of to in the file makes it build just fine on Linux. diff attached. diff.txtsize_t``std::size_t``vita3k/io/include/io/file.h

thanks, sir

@Macdu
Copy link
Contributor

Macdu commented May 20, 2024

Don't replace size_t with std::size_t, instead add #include <cstddef> at the top of io/file.h

@Croden1999
Copy link
Contributor Author

Don't replace with , instead add at the top of io/file.hsize_t``std::size_t``#include <cstddef>

got it, thanks, sir.

@Croden1999 Croden1999 force-pushed the window branch 2 times, most recently from d540d13 to cc31690 Compare May 20, 2024 10:35
Should fix Linux build.
Copy link
Contributor

@Macdu Macdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

@Macdu Macdu merged commit 6bfe087 into Vita3K:master May 20, 2024
9 checks passed
@Croden1999
Copy link
Contributor Author

Croden1999 commented May 20, 2024

You're welcome, sir, also i want say thank you again.

@Croden1999 Croden1999 deleted the window branch May 21, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app gui/lang gui io Related to io/filesystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants