Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving Grunt tasks to Webpack 2 #92

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

leshek-pawlak
Copy link

Hi guys,

Thanks for developing this project.
I'm using it and I think is really great.
This time I want to share my work with the others.
I rewrote all grunt tasks to webpack.
For my needs, it's working well, but please check if every task you need is included to webpack.

I hope it will help be more productive all developers contributing the WebVOWL.
By the way, I've added PostCSS Autoprefixer for CSSs and updated webpack to 2 version.

Cheers,
Leszek

@leshek-pawlak
Copy link
Author

#85

@linkvt
Copy link
Member

linkvt commented May 8, 2017

Hi,
thank you for this PR, after taking a quick look over it, it seems interesting and I could learn something from it.
Since I'm currently not an active maintainer somebody else should approve this PR when its finished/accepted.

I noticed a few things that should be adjusted if the switch to webpack is accepted:

I really like the addition of autoprefixer for a better compatibility and it might allow to tidy the current CSS a bit.

Thanks

@leshek-pawlak
Copy link
Author

Hi @linkvt,

Thanks for your message.
I'm glad that you think it's interesting. :)
I'll fix the travis bug and I'll change a little bit README file - they're simple things.

Now I see what's doing this "grunt-bump" plugin.
I'll try to find webpack solution for that.

@leshek-pawlak
Copy link
Author

I did some research in the "bumping" tools for webpack and CLI.
I think that grunt-bump is the best solution nowadays.
There is no reason to change it to another tool.

Please check again if my changes are acceptable for you.

@linkvt
Copy link
Member

linkvt commented May 9, 2017

Thanks for your changes, I really appreciate it.
I still have to refer to the comment of Steffen that he will consider it with the current maintainer, since I'm not actively involved in the development process anymore - so I can't decide if this PR will be accepted.

@linkvt linkvt requested review from vitalis-wiens and removed request for vitalis-wiens October 1, 2017 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants