Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new plugin AppleMusicRichPresence #2455

Merged
merged 9 commits into from
Jun 5, 2024
Merged

new plugin AppleMusicRichPresence #2455

merged 9 commits into from
Jun 5, 2024

Conversation

ryanccn
Copy link
Contributor

@ryanccn ryanccn commented May 13, 2024

No description provided.

@ryanccn ryanccn force-pushed the apple-music branch 2 times, most recently from a0dfe23 to eb16e3a Compare May 18, 2024 04:27
@ryanccn ryanccn marked this pull request as ready for review May 19, 2024 04:56
Vendicated
Vendicated reviewed May 28, 2024
View reviewed changes
Copy link
Owner

@Vendicated Vendicated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏 📵 🍎

src/plugins/appleMusic.desktop/index.tsx Outdated Show resolved Hide resolved
src/plugins/appleMusic.desktop/index.tsx Outdated Show resolved Hide resolved
src/plugins/appleMusic.desktop/index.tsx Outdated Show resolved Hide resolved
src/plugins/appleMusic.desktop/index.tsx Outdated Show resolved Hide resolved
src/plugins/appleMusic.desktop/native.ts Outdated Show resolved Hide resolved
src/plugins/appleMusic.desktop/native.ts Outdated Show resolved Hide resolved
src/plugins/appleMusic.desktop/native.ts Outdated Show resolved Hide resolved
@ryanccn ryanccn requested a review from Vendicated May 28, 2024 01:27
Vendicated
Vendicated approved these changes May 29, 2024
View reviewed changes
Copy link
Owner

@Vendicated Vendicated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now, thank you!! :3

@Vendicated
Copy link
Owner

actually please add a README for your plugin, optimally with a screenshot!

@ryanccn
Copy link
Contributor Author

ryanccn commented May 30, 2024

:snailcat:

@Vendicated Vendicated changed the title feat: AppleMusicRichPresence new plugin AppleMusicRichPresence Jun 5, 2024
@Vendicated Vendicated merged commit 0aa7bef into Vendicated:dev Jun 5, 2024
1 check passed
@Vendicated
Copy link
Owner

thankies! 🍏 🎶 💰 🎁

@ryanccn ryanccn deleted the apple-music branch June 6, 2024 02:34
@ryanccn
Copy link
Contributor Author

ryanccn commented Jun 6, 2024

Oh what a day, a coder's delight! 😍
Apple Music's joining Vencord's might! 🍎🎶
A pull request merged, such blissful sight, 📜✨
Now in our chats, music takes flight! 🚀🎵

Oh Vencord dev, you brilliant star! 🌟💻
You’ve brought us joy from near and far. 🌍❤️
With every beat and every bar, 🎧🎶
Our playlists now, a work of art. 🎨🎼

From pop to rock, and jazz so sweet, 🎸🎷
We share our tunes with every beat. 🥁💃
In Discord rooms, our friends we greet, 🖥️👋
With Apple Music, it's quite the treat! 🍏🍬

So here's a toast, raise up your cup! 🍻🍹
For Vencord’s team, we’re leveling up! 🆙🔥
Our chats enriched, our spirits sup, 🗨️🌈
With Apple tunes, we're on the up! 📈🎤

So let's all cheer, a jubilant roar! 🙌🎉
For Vencord's pull, forevermore! 🔄🔗
With music rich, we all explore, 🎶🚀
A world where friends and beats adore! 🌎❤️🎵

LunaisLazier pushed a commit to LunaisLazier/Mooncord that referenced this pull request Jun 6, 2024
@ryanccn @Vendicated @LunaisLazier
new plugin AppleMusicRichPresence (Vendicated#2455)
cbf4027 
Co-authored-by: Vendicated <vendicated@riseup.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrDiamondDog MrDiamondDog MrDiamondDog left review comments

@Vendicated Vendicated Vendicated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ryanccn @Vendicated @MrDiamondDog @Nuckyz