Plugin: Media downloader #2349
Plugin: Media downloader #2349
Conversation
…on to use media downloader settings
There was a problem hiding this comment.
Wow, this looks great so far, especially for a first time contributor!
This is only a partial review for now, mainly cause i feel bad for taking so long to get to it
I'll have to do a more thorough review soon, hopefully tomorrow, due to the size & potential security issues there could be
I still see a bunch of TODO comments... Do you need help with those or are you still working on them?
|
|
||
| function DirectoryPickerComponent(props: { setValue(v: any): void; }) { | ||
| const [value, setValue] = useState(""); | ||
| useEffect(() => { Native.getMediaFolder().then(setValue).catch(console.log); }); |
There was a problem hiding this comment.
this is a bit strange, it'd be better to do something like:
const [signal, forceUpdate] = useForceUpdater(true);
const [value, error, isLoading] = useAwaiter(Native.getMediaFolder, {
deps: [signal],
defaultValue: null
})this will properly handle the promise & error handling for you and calling forceUpdate will re-run it
| } | ||
|
|
||
| function getNativeSettings() { | ||
| if (!NativeSettings.store.plugins) NativeSettings.store.plugins = {}; |
There was a problem hiding this comment.
| if (!NativeSettings.store.plugins) NativeSettings.store.plugins = {}; | |
| NativeSettings.store.plugins ??= = {}; |
| return Native | ||
| .downloadFile(uri, uri) | ||
| .then(success => console.log(success)) | ||
| .catch(error => console.log(error)); |
There was a problem hiding this comment.
these should definitely notify the user in some other way, e.g. a toast
| { | ||
| find: "AnalyticEvents.MEDIA_DOWNLOAD_BUTTON_TAPPED", | ||
| replacement: { | ||
| match: /href:(\w{1,3}),onClick:(\w{1,3}),target:(\w{1,3}),rel:(\w{1,3}),className:(\w{1,3}),"aria-label":(\w{1,3}).default.Messages.DOWNLOAD,/g, |
There was a problem hiding this comment.
Vencord has a custom \i escape sequence that matches identifiers!
| match: /href:(\w{1,3}),onClick:(\w{1,3}),target:(\w{1,3}),rel:(\w{1,3}),className:(\w{1,3}),"aria-label":(\w{1,3}).default.Messages.DOWNLOAD,/g, | |
| match: /href:(\i),onClick:(\w{1,3}),target:(\w{1,3}),rel:(\w{1,3}),className:(\w{1,3}),"aria-label":(\w{1,3}).default.Messages.DOWNLOAD,/g, |
| message, | ||
| channel: ChannelStore.getChannel(message.channel_id), | ||
| onClick: async () => { | ||
| // console.log("Attachments:"); |
There was a problem hiding this comment.
please remove all these debug lines once you're done
also might i suggest using the debugger instead? it's underrated! you can just search some code of your plugin in devtools (ctrl shift f), jump to the source code (make sure you have js source maps enabled) and put breakpoints
Depends on #2346
Addresses plugin request Vencord/plugin-requests#188
Many TODOs still but it's working pretty well for what it is so I figured I could put it in the review queue and if I get more time to work on it I'll just keep adding on.
Features (each can be enabled/disabled individually):