Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[Plugin] showBadgeInChat #2347

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Conversation

KrstlSkll69
Copy link

@KrstlSkll69 KrstlSkll69 commented Apr 10, 2024

supersedes the abandoned #1980 (Is also just complete rewrite of it)

Shows the message author's badges beside their name in chat.
The badges include all built-in Discord badges.
It also proudly displays your Vencord donor/contributor badges.


The settings editor lets you:

  • Drag to reorder
  • Click to enable/disable a specific badge type
  • Hover over a badge for the tool-tip about what badges it represents

An example of what the menu looks like ↓
ExampleOfTheIntreface


Vencord Creator: Vee (vending.machine) badge's ↓
VencordCreator'sBadges


Video of menu in action ↓
https://github.com/Vendicated/Vencord/assets/150982280/5ebc21cc-19dc-4cf9-b988-c95eae1f9ca5


Discord currently has a small bug where an author who isn't the current user will return their premiumType as undefined. There is nothing we can do about this until Discord fixes this bug

@byeoon
Copy link
Sponsor Contributor

byeoon commented Apr 10, 2024

LGTM although will it show Nitro badges? (Boost, etc)

Copy link
Contributor

@Inbestigator Inbestigator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and quite polished.

@Inbestigator
Copy link
Contributor

LGTM although will it show Nitro badges? (Boost, etc)

Yes

@KrstlSkll69
Copy link
Author

I am very sorry, This is like my third time using github, but I fucked up and this was my attempt to fix it. I hope it work. 😭

@KrstlSkll69
Copy link
Author

I'm going to bump this because even tho it's lost in hell, I see at least one white name a day ask for a plug-in that does exactly this

@KrstlSkll69 KrstlSkll69 changed the title showBadgeInChat feat[Plugin] showBadgeInChat May 15, 2024
@waterbufalowalking

This comment was marked as spam.

@byeoon
Copy link
Sponsor Contributor

byeoon commented May 26, 2024

i hope this gets merged soon

@KrstlSkll69
Copy link
Author

i hope this gets merged soon

thank u for your kinda words i hope so too, Its almost everyday i see someone asking for plugin. So i also hope it gets merged too. <3 ;3

Copy link
Owner

@Vendicated Vendicated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meow

src/plugins/showBadgesInChat/settings.tsx Outdated Show resolved Hide resolved
src/plugins/showBadgesInChat/styles.css Outdated Show resolved Hide resolved
src/utils/constants.ts Outdated Show resolved Hide resolved
src/plugins/showBadgesInChat/settings.tsx Outdated Show resolved Hide resolved
src/plugins/showBadgesInChat/index.tsx Outdated Show resolved Hide resolved
src/plugins/showBadgesInChat/index.tsx Outdated Show resolved Hide resolved
src/plugins/showBadgesInChat/README.md Outdated Show resolved Hide resolved
src/plugins/showBadgesInChat/README.md Outdated Show resolved Hide resolved
src/plugins/showBadgesInChat/index.tsx Outdated Show resolved Hide resolved
KrstlSkll69 and others added 3 commits May 27, 2024 20:59
Co-authored-by: vee <vendicated@riseup.net>
Co-authored-by: vee <vendicated@riseup.net>
Co-authored-by: vee <vendicated@riseup.net>
@KrstlSkll69
Copy link
Author

i think everything is fixed @Vendicated

Copy link
Owner

@Vendicated Vendicated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for better maintainability and catching bugs before they occur, try to avoid using the any type. here you already have strong types on everything so there's no reason to use all these anys

src/plugins/showBadgesInChat/index.tsx Outdated Show resolved Hide resolved
src/plugins/showBadgesInChat/index.tsx Outdated Show resolved Hide resolved
src/plugins/showBadgesInChat/index.tsx Outdated Show resolved Hide resolved
src/plugins/showBadgesInChat/index.tsx Outdated Show resolved Hide resolved
src/plugins/showBadgesInChat/index.tsx Outdated Show resolved Hide resolved
src/plugins/showBadgesInChat/index.tsx Outdated Show resolved Hide resolved
Mrrooww

Co-authored-by: vee <vendicated@riseup.net>
@KrstlSkll69
Copy link
Author

ok committed

@KrstlSkll69
Copy link
Author

misclicked, didnt mean to do that

@KrstlSkll69
Copy link
Author

ok bug fix, thx @Inbestigator for spotting that

@KrstlSkll69
Copy link
Author

@Inbestigator is a meanie whom keeps waking me up*(joke)*, forgot the style import earlier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants