-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin): CustomIdle #2342
feat(plugin): CustomIdle #2342
Conversation
ngl i think it'd be better to do like a "You are currently still idle. Click the button to exit idle" bar instead of the grace period also bc the way I animated the grace period notification is kinda ugly lemme change that |
keep in mind that this idle timer is coupled with mobile notifications. so if you set it to a very high number or disable it outright, it might break mobile notifications |
oh ok i'll make a more precise patch for disabling then |
Cool af |
Bump |
Did some testing with this and feel it’s ready for use. Vesktop currently does not handle Idling very well and this as a workaround seems like a fair consideration to me. Could not produce any bugs with this branch. At this time, I have to run four Discord tabs, instead of two to keep my Discord online at all times, which is incredibly inefficient. How ready would you say this is or what’s blocking this from being added to the plugin library, @Vendicated? |
Requesting addition here, works well |
I was deperatly looking for a plugin like this. When I have Discord open on my second monitor and have an eye on it, I am there. Hands on my keyboard and mouse, and always an eye on Discord. But I still get set to idle when I don't actually click into the client for too long and then they think I'm not available and nobody messages me any more :( I'm so glad there's a plugin in development to fix this!! |
it can be installed, but it's not an official plugin yet (vee needs to approve it first) so you need to install the dev version of Vencord. then you download the index.ts in this pull request and you move it to however you won't get any support with dev versions/unofficial plugins like this one so you have to figure it out yourself in the end |
I'm so happy you've made this dream come true! I understand it isn't officially released, But, I found it amazing how BetterDiscord had something like it, and I was just wondering beyond wonder why Vencord didn't have any option for it! Thanks @waresnew |
@R00tB33rMan there's nothing blocking it from being merged, it's just that i haven't gotten to it yet! there's quite the backlog of pull requests so it sadly takes a while sometimes. anyway ill look at this some time in the coming few days you (and anyone reading this) can always help by testing open pull requests early and testing their functionality. see if all works as expected, if there are any bugs or if there is any behaviour that you think might be confusing, then leave constructive feedback to the author for example in this pr it'd be good to test & report if this causes any issues / edge cases with mobile notifications or if those work flawlessly |
please add a readme file |
ok it looks like a lot of people use this plugin to partially solve idling while the window is in the foreground i'm not sure if it's feasible to globally capture user input even when the window's unfocused in terms of formatting, i can't access vscode rn so i'll fix it in like 10 hours i'll add a readme in a moment |
I have applied my suggestion of a better handling for showing the notice, and also better formatting. But the issues I mentioned are still present |
oh, i see edit: it looks like that setInterval is only run when on web discord (I only tested on desktop so ig that's why I didn't notice) i'm a bit busy rn so i'll add a patch for that in a few days ty for reviewing |
ok i just realized that setInterval's delay has to be a 32 bit integer so MAX_SAFE_INTEGER was making it overflow to 0 💀 technically this made it so the setinterval was still being run but this probably caused lag |
so this still needs work if i'm understanding correctly? marking as draft accordingly |
ok it won't prevent you from being AFK on web installs now i'm gonna unmark it as draft now |
Great fix, just these three nitpicks and it should be ready |
Co-authored-by: Nuckyz <61953774+Nuckyz@users.noreply.github.com>
Co-authored-by: Nuckyz <61953774+Nuckyz@users.noreply.github.com>
Co-authored-by: Nuckyz <61953774+Nuckyz@users.noreply.github.com>
okk made the changes 👍 |
Thank you for the new plugin! |
Hol up! This working now?? @Nuckyz |
When it gets released to the main branch, yes |
Thank you all for your hard work. I really appreciate everyone's interest in improving the user experience and am glad that this was merged through everyone's availability and persistence. |
Fulfills Vencord/plugin-requests#199
Main feature is changing the timer until your status gets set to idle (or preventing auto-idle forever)
There's also a confirmation notification where it'll let you stay idle, even if you come back to Discord
You'll stay idle until you click "Exit idle"