.NET examples #7061
.NET examples #7061
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
🥳 Great work!
Minor suggestions here to complement this examples doc:
- Adding a link to the Examples doc in the .NET tutorial doc as part of this PR.
In the tutorial conclusion, you could add at the bottom:
"Continue to our .NET Examples docs for more advanced applications of feature flags in .NET."
I think that's it from me! 👍
| - [Configure strategy constraints for canary deployments](#configure-strategy-constraints-for-canary-deployments) | ||
| - [Server-side A/B Testing in .NET](#server-side-ab-testing-in-net) | ||
| - [Feature Flag Analytics and Reporting in .NET](#feature-flag-analytics-and-reporting-in-net) | ||
| - [Enable impression data events in .NET](#enable-impression-data-events-in-net) |
There was a problem hiding this comment.
In the section linked to here, perhaps add an example of how to hook into the impression data events in the app using the SDK? Or is this article more about how to integrate with the admin API from .NET?
There was a problem hiding this comment.
Could also just be a link to the relevant section in the repo/docs
There was a problem hiding this comment.
@daveleek I'll let Alvin know that it'd be good to add an example of using impression data events in the app as a fast-follow to this PR. Based off the docs we have on it https://docs.getunleash.io/reference/sdks/dotnet#handling-events
| ```csharp | ||
| HttpClient client = new HttpClient(); | ||
|
|
||
| string url = "<your-unleash-url>/api/admin/projects/:projectId/features/:featureName/environments/:environment/strategies/:strategyId"; |
There was a problem hiding this comment.
| string url = "<your-unleash-url>/api/admin/projects/:projectId/features/:featureName/environments/:environment/strategies/:strategyId"; | |
| string url = $"{unleashUrl}/api/admin/projects/{projectId}/features/{featureName}/environments/{environment}/strategies/{strategyId}"; |
Perhaps do something like this for these urls so if people copy+paste then they get build errors for missing parameters instead of weird responses from Unleash.
| ```csharp | ||
| HttpClient client = new HttpClient(); | ||
|
|
||
| string url = "<your-unleash-url>/api/admin/projects/<your-project-id>/features/<your-feature-flag>/environments/<your-environment>/strategies/3a76899f-582b-422f-be72-34c995388f77"; |
There was a problem hiding this comment.
Same here and for the urls further down. and you've accidentally included a reference to one of your own strategies here?
There was a problem hiding this comment.
Good work @alvinometric! Couple of questions/thoughts around adding more context to impression events and urls with parameter placeholders but feel free to ignore!
Another one for you @daveleek 🙏