feat: deprecate feature toggle variants at environment level #7058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Comment on lines
+183
to
+191
| ...(showLegacyVariants | ||
| ? [ | ||
| { | ||
| title: 'Variants', | ||
| path: `${basePath}/variants`, | ||
| name: 'Variants', | ||
| }, | ||
| ] | ||
| : []), |
There was a problem hiding this comment.
Just commenting on what we talked about: maybe for some users will be confusing to see the tab in a feature with variants and don't see the tab in another feature in the same project, which might cause them to communicate via slack or a ticket. To prevent this communication overhead, maybe we can show the tab with a deprecated icon, but hide the content (so you'd be only able to edit environment variants if you had them, but not if you don't)
kwasniew
deleted the
deprecate-feature-toggle-variants-at-environment-level
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Variants tab will be hidden for new features and feature that don't use environment variants.
We'd like to encourage the usage of the strategy variants. Env variants are still kept for the features that already use them for backwards compatibility.
Variants in this tab will be gone for new features and existing features without env variants
We also have a sunset flag called "enableLegacyVariants" that can be used to enable environment variants even for the new features.
This PR also updates docs with a deprecation notice.
Next PR will be created to block environment variants in the backend API.
Important files
Discussion points
Original PR #7054 was working at the instance level but we found that feature level deprecation is more versatile and simpler.