Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of odmr logic to provide fit of multiple ranges in perform_odmr_measurement #681

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ksenkalla
Copy link
Contributor

@ksenkalla ksenkalla commented Sep 14, 2021

Description

The method perform_odmr_measurement was adjusted to fit in the multiple ranges and also save the fit in these ranges. Before the fit values were not changed for all ranges.

Motivation and Context

Now every in every range the corresponding fit is saved in the corresponding file.

How Has This Been Tested?

Tested by automized measurement using jupyter notebook.
Tested on Microsoft Windows 8.1 Pro

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have documented my changes in the changelog (documentation/changelog.md)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added/updated for the module the config example in the docstring of the class accordingly.
  • I have checked that the change does not contain obvious errors (syntax, indentation, mutable default values).
  • I have tested my changes using 'Load all modules' on the default dummy configuration with my changes included.
  • All changed Jupyter notebooks have been stripped of their output cells.

@NicolasStaudenmaier NicolasStaudenmaier added this to In progress in CW ODMR via automation Sep 28, 2021
@Geegee Geegee mentioned this pull request Sep 30, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
CW ODMR
In progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant