Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Fix in confocalgui. #672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LukePiewalker
Copy link

@LukePiewalker LukePiewalker commented Jul 28, 2021

Qudi crashes on too large clock frequencies while heavily scrolling on the precentiles colorbar range (also happens with the dummy). This few line fix, seems to prevent the issue.

Description

Flattened the array while assiging it to a new variable. Maybe prevents change of Image during runtime which might cause the issue?

Motivation and Context

Qudi crashes while scrolling on the percentile colorbar

How Has This Been Tested?

Dummy Confocal on Win10.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have documented my changes in the changelog (documentation/changelog.md)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added/updated for the module the config example in the docstring of the class accordingly.
  • I have checked that the change does not contain obvious errors (syntax, indentation, mutable default values).
  • I have tested my changes using 'Load all modules' on the default dummy configuration with my changes included.
  • All changed Jupyter notebooks have been stripped of their output cells.

… while heavily scrolling on the precentiles range (also happens with the dummy). This few line fix, seems to prevent the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant