Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T100S_HP laser hardware module #635

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

alrik-durand
Copy link
Contributor

@alrik-durand alrik-durand commented Dec 14, 2020

Description

This PR adds support to the T100S_HP laser via the simple laser interface

Motivation and Context

This PR adds support to new hardware.
The laser added here is a tunable laser. Simple_laser interface does not support this feature so a new interface / modification will be necessary at a later time. This PR only focus on the hardware.

How Has This Been Tested?

This has been tested with the laser connected via GPIB with a windows 10 computer.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have documented my changes in the changelog (documentation/changelog.md)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added/updated for the module the config example in the docstring of the class accordingly.
  • I have checked that the change does not contain obvious errors (syntax, indentation, mutable default values).
  • I have tested my changes using 'Load all modules' on the default dummy configuration with my changes included.
  • All changed Jupyter notebooks have been stripped of their output cells.

@Neverhorst Neverhorst added this to In progress in Laserstuff via automation Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Laserstuff
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant