Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thorlabs flipper - Switch interface #603

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

alrik-durand
Copy link
Contributor

Description

I've added a hardware module to interface Thorlabs flipper MF101 with the switch interface.
It uses the recommended method via Kinesis dll.

Motivation and Context

This PR add support to new material.

How Has This Been Tested?

This has been tested with a MFF101/M on windows 10.

Screenshots (only if appropriate, delete if not):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have documented my changes in the changelog (documentation/changelog.md)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added/updated for the module the config example in the docstring of the class accordingly.
  • I have checked that the change does not contain obvious errors (syntax, indentation, mutable default values).
  • I have tested my changes using 'Load all modules' on the default dummy configuration with my changes included.
  • All changed Jupyter notebooks have been stripped of their output cells.

@alrik-durand alrik-durand mentioned this pull request Oct 22, 2020
11 tasks
@alrik-durand
Copy link
Contributor Author

I've updated the hardware to conform to the new interface.
I had to copy/past the states functions from the interface because otherwise I get an error. There seems to be a conflict between interface overloading (not used by this hardware) and attribute/setter methods.
The copying and pasting of the default implementation prevent the problem, but it should probably be solved properly.

@Neverhorst
Copy link
Member

@alrik-durand: See PR #641

@Neverhorst
Copy link
Member

Did PR #641 resolve the issue mentioned in your latest comment, @alrik-durand?
Should not be necessary to copy the states method over anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants