Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run extensions on demand #1020

Draft
wants to merge 3 commits into
base: v6
Choose a base branch
from
Draft

Run extensions on demand #1020

wants to merge 3 commits into from

Conversation

friday
Copy link
Member

@friday friday commented Apr 27, 2022

See #1063

This PR will wait to load the extension until the keyword is called, and then unloads it when the window is hidden.

This is more of a "proof of concept" for now since it doesn't fully work as it should yet.

  1. Does not implement the new APIs we would need
  2. Doesn't properly handle the initial user input. The extension controller is created by a callback event that's kickstarted by the extension runner and handled in ExtensionServer when it receives handle_registration. I haven't figured out how to tap into that workflow.

This change has other good side effects besides saving lots of ram. Ulauncher loads insanely fast in comparison, and the Preferences window also loads faster.

Checklist

  • Verify that the test command ./ul test is passing (the CI server will check this if you don't)
  • Update the documentation according to your changes (when applicable)
  • Write unit tests for your changes (when applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant