Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core/Creatures: Check fallback difficulty data for creature static flags override #29992

Merged
merged 1 commit into from
May 23, 2024
Merged

Core/Creatures: Check fallback difficulty data for creature static flags override #29992

merged 1 commit into from
May 23, 2024

Conversation

meji46
Copy link
Member

@meji46 meji46 commented May 15, 2024

Changes proposed:

  • Check fallback difficulty data for creature static flags override. We can override the static flags of a spawn with several difficulties without inserting the same data for each difficulty

Issues addressed:
None

Tests performed:
Builds, tested in-game.

Known issues and TODO list: (add/remove lines as needed)
None

@meji46 meji46 merged commit e516707 into TrinityCore:master May 23, 2024
5 checks passed
@meji46 meji46 deleted the creature/static-flags-override-fallback branch May 23, 2024 19:48
Ovahlord pushed a commit that referenced this pull request May 28, 2024
@meji46 @Ovahlord
Core/Creatures: Check fallback difficulty data for creature static fl…
3451ce7 
…ags override (#29992)

(cherry picked from commit e516707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BertiRean BertiRean BertiRean left review comments

@mdX7 mdX7 mdX7 approved these changes

Assignees
No one assigned
Labels
Branch-master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@meji46 @mdX7 @BertiRean