Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core/AreaTriggers: Move SpellForVisuals override from AT spawn to properties #29982

Merged
merged 3 commits into from
May 18, 2024
Merged

Core/AreaTriggers: Move SpellForVisuals override from AT spawn to properties #29982

merged 3 commits into from
May 18, 2024

Conversation

meji46
Copy link
Member

@meji46 meji46 commented May 12, 2024

Changes proposed:

  • Move SpellForVisuals override from AT spawn to properties. We can override SpellForVisuals inherited from summoning spell/aura

Issues addressed:
None

Tests performed:
Builds, tested in-game. Spell 295663 summons an AT using 294566 as SpellForVisuals

Known issues and TODO list: (add/remove lines as needed)
None

@meji46 meji46 requested a review from Golrag May 12, 2024 18:06
@Shauren
Copy link
Member

Shauren commented May 14, 2024

So spawns cannot override it anymore?

@meji46
Copy link
Member Author

meji46 commented May 14, 2024 •
edited

So spawns cannot override it anymore?

Spawns also use createproperties

@Shauren
Copy link
Member

Shauren commented May 14, 2024

Oh, I forgot about that

@mdX7 mdX7 merged commit 2ad7c78 into TrinityCore:master May 18, 2024
2 of 5 checks passed
@meji46 meji46 deleted the areatrigger/spell-visual branch May 18, 2024 07:43
Ovahlord pushed a commit that referenced this pull request May 28, 2024
@meji46 @Ovahlord
Core/AreaTriggers: Move SpellForVisuals override from AT spawn to pro…
ec95f60 
…perties (#29982)

(cherry picked from commit 2ad7c78)

# Conflicts:
#	src/server/game/Entities/AreaTrigger/AreaTrigger.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Golrag Golrag Golrag approved these changes

@mdX7 mdX7 mdX7 approved these changes

Assignees
No one assigned
Labels
Branch-master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@meji46 @Shauren @Golrag @mdX7